[v3,0/3] ASoC: Intel: Add KeemBay ASoC platform driver

Message

Sia Jee Heng June 1, 2020, 9:53 a.m. UTC

The below series of patches support the KeemBay ASoC platform driver.
The platform driver initialize the i2s to capture and playback the
pcm data on the ARM. The i2s is running in polling mode.

There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin
to perform Audio preprocessing.

Audio graph card is used to connect the platform driver with the
tlv320aic3204 codec.

Change History:
v3:
- Adjusted header format.
- Use Audio graph card instead of custom sound card.
- Use if-else instead of conditional operator.
- Enabled .set_fmt to configure master clock.

v2:
- Corrected I2S naming for DT binding.

v1:
- Initial version.

Sia Jee Heng (3):
  ASoC: Intel: Add KeemBay platform driver
  ASoC: Intel: Add makefiles and kconfig changes for KeemBay
  dt-bindings: sound: Add documentation for KeemBay i2s

 .../bindings/sound/intel,keembay-i2s.yaml          |  68 +++
 sound/soc/intel/Kconfig                            |   7 +
 sound/soc/intel/Makefile                           |   1 +
 sound/soc/intel/keembay/Makefile                   |   4 +
 sound/soc/intel/keembay/kmb_platform.c             | 667 +++++++++++++++++++++
 sound/soc/intel/keembay/kmb_platform.h             | 145 +++++
 6 files changed, 892 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/intel,keembay-i2s.yaml
 create mode 100644 sound/soc/intel/keembay/Makefile
 create mode 100644 sound/soc/intel/keembay/kmb_platform.c
 create mode 100644 sound/soc/intel/keembay/kmb_platform.h

Comments

Cezary Rojewski June 1, 2020, 9:30 p.m. UTC | #1

On 2020-06-01 11:53 AM, Sia Jee Heng wrote:
> The below series of patches support the KeemBay ASoC platform driver.
> The platform driver initialize the i2s to capture and playback the
> pcm data on the ARM. The i2s is running in polling mode.
> 
> There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin
> to perform Audio preprocessing.
> 
> Audio graph card is used to connect the platform driver with the
> tlv320aic3204 codec.
> 
> Change History:
> v3:
> - Adjusted header format.
> - Use Audio graph card instead of custom sound card.
> - Use if-else instead of conditional operator.
> - Enabled .set_fmt to configure master clock.
> 
> v2:
> - Corrected I2S naming for DT binding.
> 
> v1:
> - Initial version.
> 
> Sia Jee Heng (3):
>    ASoC: Intel: Add KeemBay platform driver
>    ASoC: Intel: Add makefiles and kconfig changes for KeemBay
>    dt-bindings: sound: Add documentation for KeemBay i2s
> 

As these series has been given plenty of comments internally from Andy, 
Pierre and me, I'd be best to have all reviewers CC'ed here.

Czarek

Sia Jee Heng June 2, 2020, 12:35 p.m. UTC | #2

-----Original Message-----
From: Rojewski, Cezary <[e-mail]> 
Sent: Tuesday, June 2, 2020 5:31 AM
To: Sia, Jee Heng <[e-mail]>
Cc: [e-mail]; [e-mail]; [e-mail]; [e-mail]; [e-mail]; Shevchenko, Andriy <[e-mail]>
Subject: Re: [PATCH v3 0/3] ASoC: Intel: Add KeemBay ASoC platform driver

On 2020-06-01 11:53 AM, Sia Jee Heng wrote:
> The below series of patches support the KeemBay ASoC platform driver.
> The platform driver initialize the i2s to capture and playback the pcm 
> data on the ARM. The i2s is running in polling mode.
> 
> There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer 
> plugin to perform Audio preprocessing.
> 
> Audio graph card is used to connect the platform driver with the
> tlv320aic3204 codec.
> 
> Change History:
> v3:
> - Adjusted header format.
> - Use Audio graph card instead of custom sound card.
> - Use if-else instead of conditional operator.
> - Enabled .set_fmt to configure master clock.
> 
> v2:
> - Corrected I2S naming for DT binding.
> 
> v1:
> - Initial version.
> 
> Sia Jee Heng (3):
>    ASoC: Intel: Add KeemBay platform driver
>    ASoC: Intel: Add makefiles and kconfig changes for KeemBay
>    dt-bindings: sound: Add documentation for KeemBay i2s
> 

As these series has been given plenty of comments internally from Andy, Pierre and me, I'd be best to have all reviewers CC'ed here.
[>>]  Noted.
Czarek

Mark Brown June 15, 2020, 11:40 p.m. UTC | #3

On Mon, 1 Jun 2020 17:53:18 +0800, Sia Jee Heng wrote:
> The below series of patches support the KeemBay ASoC platform driver.
> The platform driver initialize the i2s to capture and playback the
> pcm data on the ARM. The i2s is running in polling mode.
> 
> There is no DSP in the KeemBay SoC. Users are rely on the Gstreamer plugin
> to perform Audio preprocessing.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: Intel: Add KeemBay platform driver
      commit: c5477e966728f8e9d1434543d4ee677d515e1078
[2/3] ASoC: Intel: Add makefiles and kconfig changes for KeemBay
      commit: c544912bcc2dc806ba71d9157ccefca4a4a885f0
[3/3] ASoC: Add documentation for KeemBay i2s
      commit: e16caedf737145f74e34e45205b15695adf66f38

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark