[v2,00/46] Trivial BTRFS_I removal
mbox series

Message ID 20200603055546.3889-1-nborisov@suse.com
Headers show
Series
  • Trivial BTRFS_I removal
Related show

Message

Nikolay Borisov June 3, 2020, 5:55 a.m. UTC
V2 with purely cosmetic changes in the line length of some patches' changelogs.

For the cover letter of substance for this series check v1 [0] cover letter.

[0] https://lore.kernel.org/linux-btrfs/SN4PR0401MB3598824C8AE02453F8ABD61A9B8B0@SN4PR0401MB3598.namprd04.prod.outlook.com/T/#t

Nikolay Borisov (46):
  btrfs: Make __btrfs_add_ordered_extent take struct btrfs_inode
  btrfs: Make get_extent_allocation_hint take btrfs_inode
  btrfs: Make btrfs_lookup_ordered_extent take btrfs_inode
  btrfs: Make btrfs_reloc_clone_csums take btrfs_inode
  btrfs: Make create_io_em take btrfs_inode
  btrfs: Make extent_clear_unlock_delalloc take btrfs_inode
  btrfs: Make btrfs_csum_one_bio takae btrfs_inode
  btrfs: Make __btrfs_drop_extents take btrfs_inode
  btrfs: Make qgroup_free_reserved_data take btrfs_inode
  btrfs: Make __btrfs_qgroup_release_data take btrfs_inode
  btrfs: Make btrfs_qgroup_free_data take btrfs_inode
  btrfs: Make cow_file_range_inline take btrfs_inode
  btrfs: Make btrfs_add_ordered_extent take btrfs_inode
  btrfs: Make cow_file_range take btrfs_inode
  btrfs: Make btrfs_add_ordered_extent_compress take btrfs_inode
  btrfs: Make btrfs_submit_compressed_write take btrfs_inode
  btrfs: Make submit_compressed_extents take btrfs_inode
  btrfs: Make btrfs_qgroup_release_data take btrfs_inode
  btrfs: Make insert_reserved_file_extent take btrfs_inode
  btrfs: Make fallback_to_cow take btrfs_inode
  btrfs: Make run_delalloc_nocow take btrfs_inode
  btrfs: Make cow_file_range_async take btrfs_inode
  btrfs: Make btrfs_dec_test_first_ordered_pending take btrfs_inode
  btrfs: Make __endio_write_update_ordered take btrfs_inode
  btrfs: Make btrfs_cleanup_ordered_extents take btrfs_inode
  btrfs: Make inode_can_compress take btrfs_inode
  btrfs: Make inode_need_compress take btrfs_inode
  btrfs: Make need_force_cow take btrfs_inode
  btrfs: Make btrfs_run_delalloc_range take btrfs_inode
  btrfs: Make btrfs_add_ordered_extent_dio take btrfs_inode
  btrfs: Make btrfs_create_dio_extent take btrfs_inode
  btrfs: Make btrfs_new_extent_direct take btrfs_inode
  btrfs: Make __extent_writepage_io take btrfs_inode
  btrfs: Make writepage_delalloc take btrfs_inode
  btrfs: Make btrfs_set_extent_delalloc take btrfs_inode
  btrfs: Make btrfs_dirty_pages take btrfs_inode
  btrfs: Make btrfs_qgroup_reserve_data take btrfs_inode
  btrfs: Make btrfs_free_reserved_data_space_noquota take btrfs_fs_info
  btrfs: Make btrfs_free_reserved_data_space take btrfs_inode
  btrfs: Make btrfs_delalloc_release_space take btrfs_inode
  btrfs: Make btrfs_check_data_free_space take btrfs_inode
  btrfs: Make btrfs_delalloc_reserve_space take btrfs_inode
  btrfs: Remove BTRFS_I calls in btrfs_writepage_fixup_worker
  btrfs: Make prealloc_file_extent_cluster take btrfs_inode
  btrfs: make btrfs_set_inode_last_trans take btrfs_inode
  btrfs: Make btrfs_qgroup_check_reserved_leak take btrfs_inode

 fs/btrfs/block-group.c       |   3 +-
 fs/btrfs/compression.c       |  10 +-
 fs/btrfs/compression.h       |   4 +-
 fs/btrfs/ctree.h             |  14 +-
 fs/btrfs/delalloc-space.c    |  33 ++--
 fs/btrfs/delalloc-space.h    |  12 +-
 fs/btrfs/extent_io.c         |  32 ++--
 fs/btrfs/extent_io.h         |   2 +-
 fs/btrfs/file-item.c         |   4 +-
 fs/btrfs/file.c              |  73 ++++----
 fs/btrfs/free-space-cache.c  |   5 +-
 fs/btrfs/inode-map.c         |   3 +-
 fs/btrfs/inode.c             | 351 +++++++++++++++++------------------
 fs/btrfs/ioctl.c             |   8 +-
 fs/btrfs/ordered-data.c      |  38 ++--
 fs/btrfs/ordered-data.h      |  10 +-
 fs/btrfs/qgroup.c            |  49 +++--
 fs/btrfs/qgroup.h            |  12 +-
 fs/btrfs/reflink.c           |  11 +-
 fs/btrfs/relocation.c        |  32 ++--
 fs/btrfs/tests/inode-tests.c |  14 +-
 fs/btrfs/transaction.h       |  12 +-
 fs/btrfs/tree-log.c          |   4 +-
 23 files changed, 369 insertions(+), 367 deletions(-)

--
2.17.1

Comments

Johannes Thumshirn June 3, 2020, 6:55 a.m. UTC | #1
For the whole series,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

One tiny nit patch 34/46 could take a newline before the S-o-b
David Sterba June 8, 2020, 3:57 p.m. UTC | #2
On Wed, Jun 03, 2020 at 08:55:00AM +0300, Nikolay Borisov wrote:
> V2 with purely cosmetic changes in the line length of some patches' changelogs.
> 
> For the cover letter of substance for this series check v1 [0] cover letter.

I'll add the series to misc-next after rc1 so any potential fixes that
we'd like to get in early are not conflicting. Thanks.
David Sterba June 17, 2020, 11:37 a.m. UTC | #3
On Wed, Jun 03, 2020 at 08:55:00AM +0300, Nikolay Borisov wrote:
> V2 with purely cosmetic changes in the line length of some patches' changelogs.
> 
> For the cover letter of substance for this series check v1 [0] cover letter.
> 
> [0] https://lore.kernel.org/linux-btrfs/SN4PR0401MB3598824C8AE02453F8ABD61A9B8B0@SN4PR0401MB3598.namprd04.prod.outlook.com/T/#t
> 
> Nikolay Borisov (46):
>   btrfs: Make __btrfs_add_ordered_extent take struct btrfs_inode
>   btrfs: Make get_extent_allocation_hint take btrfs_inode
>   btrfs: Make btrfs_lookup_ordered_extent take btrfs_inode
>   btrfs: Make btrfs_reloc_clone_csums take btrfs_inode
>   btrfs: Make create_io_em take btrfs_inode
>   btrfs: Make extent_clear_unlock_delalloc take btrfs_inode
>   btrfs: Make btrfs_csum_one_bio takae btrfs_inode
>   btrfs: Make __btrfs_drop_extents take btrfs_inode

I've applied 1-8 to misc-next, that's what applied cleanly when I first
looked at the series and still applies now, with a minor conflict and
manual fix to recently added "btrfs: fix RWF_NOWAIT writes blocking on
extent locks and waiting for IO".

46 in one go seem to be too much, I'll try to apply the rest in case the
fixups won't get out of hand.
David Sterba June 22, 2020, 6:51 p.m. UTC | #4
On Wed, Jun 17, 2020 at 01:37:59PM +0200, David Sterba wrote:
> On Wed, Jun 03, 2020 at 08:55:00AM +0300, Nikolay Borisov wrote:
> > V2 with purely cosmetic changes in the line length of some patches' changelogs.
> > 
> > For the cover letter of substance for this series check v1 [0] cover letter.
> > 
> > [0] https://lore.kernel.org/linux-btrfs/SN4PR0401MB3598824C8AE02453F8ABD61A9B8B0@SN4PR0401MB3598.namprd04.prod.outlook.com/T/#t
> > 
> > Nikolay Borisov (46):
> >   btrfs: Make __btrfs_add_ordered_extent take struct btrfs_inode
> >   btrfs: Make get_extent_allocation_hint take btrfs_inode
> >   btrfs: Make btrfs_lookup_ordered_extent take btrfs_inode
> >   btrfs: Make btrfs_reloc_clone_csums take btrfs_inode
> >   btrfs: Make create_io_em take btrfs_inode
> >   btrfs: Make extent_clear_unlock_delalloc take btrfs_inode
> >   btrfs: Make btrfs_csum_one_bio takae btrfs_inode
> >   btrfs: Make __btrfs_drop_extents take btrfs_inode
> 
> I've applied 1-8 to misc-next, that's what applied cleanly when I first
> looked at the series and still applies now, with a minor conflict and
> manual fix to recently added "btrfs: fix RWF_NOWAIT writes blocking on
> extent locks and waiting for IO".
> 
> 46 in one go seem to be too much, I'll try to apply the rest in case the
> fixups won't get out of hand.

Still a lot of fixups, I'll keep it in a topic branch in for-next to
reduce conflict surface but will push it to misc-next at rc3 time.

The transition to btrfs_inode is worth, but please let's do it in
smaller batches next time, 20 patches should be ok. The turnaround time
should be shorter as the expected number of post-merge window fixes is
now going to be low. Thanks.