[v2,0/6] add regmap & indirect access support
mbox series

Message ID 1592493910-30473-1-git-send-email-yilun.xu@intel.com
Headers show
Series
  • add regmap & indirect access support
Related show

Message

Xu Yilun June 18, 2020, 3:25 p.m. UTC
Updated the regmap & indirect access support for spi-altera.

Patch #1, #2, #3 is already applied.
Patch #4 is an 1:1 replacement of of readl/writel with regmap_read/write
Patch #5 introduced a new platform_device_id to support indirect access as
         a sub device.
Patch #6 is a minor fix.

Main changes from v1: 
 - Split the v1 Patch #4 to v2 Patch #4 & #5. 
 - Add a new platform_device_id to support indirect access.
 - Removed the v1 Patch #5. Now we use driver name string directly.
 - Add Yilun's Signed-off-by for Patch #6


Matthew Gerlach (1):
  spi: altera: fix size mismatch on 64 bit processors

Xu Yilun (5):
  spi: altera: add 32bit data width transfer support.
  spi: altera: add SPI core parameters support via platform data.
  spi: altera: add platform data for slave information.
  spi: altera: use regmap-mmio instead of direct mmio register access
  spi: altera: support indirect access to the registers

 drivers/spi/Kconfig        |   1 +
 drivers/spi/spi-altera.c   | 177 +++++++++++++++++++++++++++++++++++++++------
 include/linux/spi/altera.h |  29 ++++++++
 3 files changed, 183 insertions(+), 24 deletions(-)
 create mode 100644 include/linux/spi/altera.h

Comments

Mark Brown June 18, 2020, 3:35 p.m. UTC | #1
On Thu, Jun 18, 2020 at 11:25:07PM +0800, Xu Yilun wrote:
> Updated the regmap & indirect access support for spi-altera.
> 
> Patch #1, #2, #3 is already applied.

The numbering for patches within a series is there *only* to say what
order things need to go in in that posting, they don't have any
relevance from one posting to another.  Sending a series with some
numbers missing causes a lot of confusion since it's not clear which
patches even exist.
Tom Rix June 18, 2020, 7:46 p.m. UTC | #2
This set looks good to me.

Reviewed-by : Tom Rix <trix@redhat.com>

Tom

On 6/18/20 8:25 AM, Xu Yilun wrote:
> Updated the regmap & indirect access support for spi-altera.
>
> Patch #1, #2, #3 is already applied.
> Patch #4 is an 1:1 replacement of of readl/writel with regmap_read/write
> Patch #5 introduced a new platform_device_id to support indirect access as
>          a sub device.
> Patch #6 is a minor fix.
>
> Main changes from v1: 
>  - Split the v1 Patch #4 to v2 Patch #4 & #5. 
>  - Add a new platform_device_id to support indirect access.
>  - Removed the v1 Patch #5. Now we use driver name string directly.
>  - Add Yilun's Signed-off-by for Patch #6
>
>
> Matthew Gerlach (1):
>   spi: altera: fix size mismatch on 64 bit processors
>
> Xu Yilun (5):
>   spi: altera: add 32bit data width transfer support.
>   spi: altera: add SPI core parameters support via platform data.
>   spi: altera: add platform data for slave information.
>   spi: altera: use regmap-mmio instead of direct mmio register access
>   spi: altera: support indirect access to the registers
>
>  drivers/spi/Kconfig        |   1 +
>  drivers/spi/spi-altera.c   | 177 +++++++++++++++++++++++++++++++++++++++------
>  include/linux/spi/altera.h |  29 ++++++++
>  3 files changed, 183 insertions(+), 24 deletions(-)
>  create mode 100644 include/linux/spi/altera.h
>
Xu Yilun June 19, 2020, 1:23 a.m. UTC | #3
On Thu, Jun 18, 2020 at 04:35:39PM +0100, Mark Brown wrote:
> On Thu, Jun 18, 2020 at 11:25:07PM +0800, Xu Yilun wrote:
> > Updated the regmap & indirect access support for spi-altera.
> > 
> > Patch #1, #2, #3 is already applied.
> 
> The numbering for patches within a series is there *only* to say what
> order things need to go in in that posting, they don't have any
> relevance from one posting to another.  Sending a series with some
> numbers missing causes a lot of confusion since it's not clear which
> patches even exist.

Thanks for your guidance. I'll take care of it.

Think I should re-send this patch to make it clear.