From patchwork Sun Jun 21 07:36:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Feng Tang X-Patchwork-Id: 11616465 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 70A151392 for ; Sun, 21 Jun 2020 07:36:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C45B23B86 for ; Sun, 21 Jun 2020 07:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C45B23B86 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2989C8D001A; Sun, 21 Jun 2020 03:36:50 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 221B38D0008; Sun, 21 Jun 2020 03:36:50 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EA358D001A; Sun, 21 Jun 2020 03:36:50 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id E77B28D0008 for ; Sun, 21 Jun 2020 03:36:49 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4F179181AC9CC for ; Sun, 21 Jun 2020 07:36:49 +0000 (UTC) X-FDA: 76952412138.11.year77_5f1575126e28 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 0AB83180F8B80 for ; Sun, 21 Jun 2020 07:36:49 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,feng.tang@intel.com,,RULES_HIT:30003:30012:30034:30054:30056:30064:30070,0,RBL:192.55.52.136:@intel.com:.lbl8.mailshell.net-64.95.201.95 62.18.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:ft,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: year77_5f1575126e28 X-Filterd-Recvd-Size: 4979 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Sun, 21 Jun 2020 07:36:46 +0000 (UTC) IronPort-SDR: AoABpERuH5kuTH4CCkcSUKxu5XVvNPHCKIQZM0eKcL+aNFdBoTteaGXFQYXUHLbvBYH0XsALRU 9mVMpdYSz2jQ== X-IronPort-AV: E=McAfee;i="6000,8403,9658"; a="123177660" X-IronPort-AV: E=Sophos;i="5.75,262,1589266800"; d="scan'208";a="123177660" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2020 00:36:45 -0700 IronPort-SDR: 2ZkjyPoeCU9wUIj4c9zkEnAOGKB/KZbBwhhJ45d23HKoc/wUjqnyRWC1lWrbR5sYW5XywW/oFQ F9IUtRHztcQg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,262,1589266800"; d="scan'208";a="478102505" Received: from shbuild999.sh.intel.com ([10.239.146.107]) by fmsmga005.fm.intel.com with ESMTP; 21 Jun 2020 00:36:41 -0700 From: Feng Tang To: Andrew Morton , Michal Hocko , Johannes Weiner , Matthew Wilcox , Mel Gorman , Kees Cook , Luis Chamberlain , Iurii Zaikin , andi.kleen@intel.com, tim.c.chen@intel.com, dave.hansen@intel.com, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Feng Tang Subject: [PATCH v5 0/3] make vm_committed_as_batch aware of vm overcommit policy Date: Sun, 21 Jun 2020 15:36:37 +0800 Message-Id: <1592725000-73486-1-git-send-email-feng.tang@intel.com> X-Mailer: git-send-email 2.7.4 X-Rspamd-Queue-Id: 0AB83180F8B80 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When checking a performance change for will-it-scale scalability mmap test [1], we found very high lock contention for spinlock of percpu counter 'vm_committed_as': 94.14% 0.35% [kernel.kallsyms] [k] _raw_spin_lock_irqsave 48.21% _raw_spin_lock_irqsave;percpu_counter_add_batch;__vm_enough_memory;mmap_region;do_mmap; 45.91% _raw_spin_lock_irqsave;percpu_counter_add_batch;__do_munmap; Actually this heavy lock contention is not always necessary. The 'vm_committed_as' needs to be very precise when the strict OVERCOMMIT_NEVER policy is set, which requires a rather small batch number for the percpu counter. So keep 'batch' number unchanged for strict OVERCOMMIT_NEVER policy, and enlarge it for not-so-strict OVERCOMMIT_ALWAYS and OVERCOMMIT_GUESS policies. Benchmark with the same testcase in [1] shows 53% improvement on a 8C/16T desktop, and 2097%(20X) on a 4S/72C/144T server. And for that case, whether it shows improvements depends on if the test mmap size is bigger than the batch number computed. We tested 10+ platforms in 0day (server, desktop and laptop). If we lift it to 64X, 80%+ platforms show improvements, and for 16X lift, 1/3 of the platforms will show improvements. And generally it should help the mmap/unmap usage,as Michal Hocko mentioned: : I believe that there are non-synthetic worklaods which would benefit : from a larger batch. E.g. large in memory databases which do large : mmaps during startups from multiple threads. Note: There are some style complain from checkpatch for patch 3, as sysctl handler declaration follows the similar format of sibling functions [1] https://lore.kernel.org/lkml/20200305062138.GI5972@shao2-debian/ patch1: a cleanup for /proc/meminfo patch2: a preparation patch which also improve the accuracy of vm_memory_committed patch3: main change This is against today's linux-mm git tree on github. Please help to review, thanks! - Feng ---------------------------------------------------------------- Changelog: v5: * rebase after 5.8-rc1 * remove the 3/4 patch in v4 which is merged in v5.7 * add code comments for vm_memory_committed() v4: * Remove the VM_WARN_ONCE check for vm_committed_as underflow, thanks to Qian Cai for finding and testing the warning v3: * refine commit log and cleanup code, according to comments from Michal Hocko and Matthew Wilcox * change the lift from 16X and 64X after test v2: * add the sysctl handler to cover runtime overcommit policy change, as suggested by Andres Morton * address the accuracy concern of vm_memory_committed() from Andi Kleen Feng Tang (3): proc/meminfo: avoid open coded reading of vm_committed_as mm/util.c: make vm_memory_committed() more accurate mm: adjust vm_committed_as_batch according to vm overcommit policy fs/proc/meminfo.c | 2 +- include/linux/mm.h | 2 ++ include/linux/mman.h | 4 ++++ kernel/sysctl.c | 2 +- mm/mm_init.c | 18 ++++++++++++++---- mm/util.c | 19 ++++++++++++++++++- 6 files changed, 40 insertions(+), 7 deletions(-)