| Message ID | 20200622172951.524306-1-drew@beagleboard.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | pinctrl: single: support #pinctrl-cells = 2 | expand |
On Mon, Jun 22, 2020 at 07:29:48PM +0200, Drew Fustini wrote: > Currently, pinctrl-single only allows #pinctrl-cells = 1. > > This series will allow pinctrl-single to also support #pinctrl-cells = 2 > > If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then > pcs_parse_one_pinctrl_entry() does an OR operation on to get the > value to store in the register. > > To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in > omap.h is modified to keep pin conf and pin mux values separate. > > change log: > - v3: change order of patches to make sure the pinctrl-single.c patch > does not break anything without the dts patches > > - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a > compile error in dtc. I had added it per suggestion from checkpatch > about having parentheses around complex values. > > Drew Fustini (3): > pinctrl: single: parse #pinctrl-cells = 2 > ARM: dts: change AM33XX_PADCONF macro separate conf and mux > ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 > > arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- > drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- > include/dt-bindings/pinctrl/omap.h | 2 +- > 3 files changed, 11 insertions(+), 4 deletions(-) > > -- > 2.25.1 > Hi Tony - do you think this series is useful as-is? Or do you want to see some usage of the seperate conf and mux values first? thanks, drew
* Drew Fustini <drew@beagleboard.org> [200629 12:29]: > Hi Tony - do you think this series is useful as-is? > > Or do you want to see some usage of the seperate conf and mux values > first? Hmm to me it seems you should squash patches 2 and 3 together as otherwise git bisect will fail to boot probably at patch 2. Regards, Tony
Currently, pinctrl-single only allows #pinctrl-cells = 1. This series will allow pinctrl-single to also support #pinctrl-cells = 2 If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then pcs_parse_one_pinctrl_entry() does an OR operation on to get the value to store in the register. To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in omap.h is modified to keep pin conf and pin mux values separate. change log: - v3: change order of patches to make sure the pinctrl-single.c patch does not break anything without the dts patches - v2: remove outer parentheses from AM33XX_PADCONF macro as it causes a compile error in dtc. I had added it per suggestion from checkpatch about having parentheses around complex values. Drew Fustini (3): pinctrl: single: parse #pinctrl-cells = 2 ARM: dts: change AM33XX_PADCONF macro separate conf and mux ARM: dts: am33xx-l4: change #pinctrl-cells from 1 to 2 arch/arm/boot/dts/am33xx-l4.dtsi | 2 +- drivers/pinctrl/pinctrl-single.c | 11 +++++++++-- include/dt-bindings/pinctrl/omap.h | 2 +- 3 files changed, 11 insertions(+), 4 deletions(-)