mbox series

[i-g-t,0/2] minor improvements to the kms_cursor_crc doc and some comments cleanup

Message ID cover.1592991729.git.melissa.srw@gmail.com (mailing list archive)
Headers show
Series minor improvements to the kms_cursor_crc doc and some comments cleanup | expand

Message

Melissa Wen June 24, 2020, 9:54 a.m. UTC
Hi,

I was studying the code of kms_cursor_crc test, and I just adjusted some comments
and added descriptions for subtests.

Melissa Wen (2):
  lib/igt_fb: change comments with fd description
  test/kms_cursor_crc: update subtests descriptions and some comments

 lib/igt_fb.c           |  6 +++---
 tests/kms_cursor_crc.c | 38 ++++++++++++++++++++++++++++----------
 2 files changed, 31 insertions(+), 13 deletions(-)

Comments

Arkadiusz Hiler July 15, 2020, 1:15 p.m. UTC | #1
On Wed, Jun 24, 2020 at 06:54:00AM -0300, Melissa Wen wrote:
> Hi,
> 
> I was studying the code of kms_cursor_crc test, and I just adjusted some comments
> and added descriptions for subtests.
> 
> Melissa Wen (2):
>   lib/igt_fb: change comments with fd description
>   test/kms_cursor_crc: update subtests descriptions and some comments

Seems like there's a conflict caused by your patch removing unused
parameters from igt_put_cairo_ctx().

Can you an send updated version and CC me on it?

In case of false positives please comment on the CI results with a short
explanation and CC Lakshmi <lakshminarayana.vudum@intel.com>

Thanks for the cleanup!