[v9,0/3] media: Add colors' order and other info over test image
mbox series

Message ID 20200701132940.21257-1-kgupta@es.iitr.ac.in
Headers show
Series
  • media: Add colors' order and other info over test image
Related show

Message

Kaaira Gupta July 1, 2020, 1:29 p.m. UTC
This patchset aims to add a method to display the correct order of
colors for a test image generated. It does so by adding a function
which returns a string of correct order of the colors for a test
pattern. It then adds a control in vimc which displays the string
over test image. It also displays some other information like saturation,
hue, contrast brightness and time since the stream started over test
image generated by vimc.

Changes since v8:
	In patch 1:
	- Add more details to commit message.
	In patch 3:
	- Formatting nits.

Changes since v7:
        In patch 3:
        - Use fallthrough; to indicate a fall through in switch-case
        - Use enum type instead of int for osd_value
        - Change varaible to osd_value instead of osd_mode as the enum
          osd_mode defines the modes.

Changes since v6:
        In patch 3:
        - Use switch case instead of if()
        - reorder declarartions.

Changes since v5:
        In patch 2:
        - Add missing EXPORT_SYMBOL_GPL()
        In patch 3:
        - Renamed varaibles.
        - use u64 instead of int for getting current time in
          nanoseconds.
        - Use enum instead of numbers to describe the state of osd_mode
          control in code.

Changes since v4:
        - Add another patch which changes char argument to const char
        in function tpg_gen_text()
        - Return const char * from function tpg_g_color_order() in patch
          2
        In 3rd patch:
        - Check font in probe() instead of s_stream()
        - Use dev_err instead of pr_err
        - Fix errors in commit message.
        - Base VIMC_CID_SHOW_INFO on VIVID_CID_OSD_TEXT_MODE

Changes since v3:
        In 1st patch:
        -Improved formatting of returned string.

        In 2nd patch:
         - Add CID prefix in control name and change it to a more
           generic name.
         - Rename bool variable to a generic name.
         - Disable text rendering instead of stopping stream if no
           font found.
         - Display more info like VIVID in VIMC.

Changes since v2:
        In 1st patch:
        - Create a 'define' to prevent repetition of the common color
          sequence string.
        - Use 'fallthrough' on case statement to prevent repetition of
          code.

Changes since v1:
        - Divided the patch into two patches.
        - Returned NULL for patterns whose color order cannot be
          defined. (Reported-by: kernel test robot <lkp@intel.com>)
        - Made separate switch cases for separate test patterns
         (Reported-by: kernel test robot <lkp@intel.com>)
        - Renamed variables from camelcase to use '_'
        - prefixed 'media' to the patches.

Kaaira Gupta (3):
  media: tpg: change char argument to const char
  media: tpg: Add function to return colors' order of test image
  media: vimc: Add a control to display info on test image

 drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 40 +++++++++--
 drivers/media/test-drivers/vimc/Kconfig       |  2 +
 drivers/media/test-drivers/vimc/vimc-common.h |  1 +
 drivers/media/test-drivers/vimc/vimc-core.c   | 10 +++
 drivers/media/test-drivers/vimc/vimc-sensor.c | 71 +++++++++++++++++++
 include/media/tpg/v4l2-tpg.h                  |  3 +-
 6 files changed, 119 insertions(+), 8 deletions(-)