[v12,0/4] Prepare for upcoming Casefolding/Encryption patches

Message

Daniel Rosenberg July 8, 2020, 9:12 a.m. UTC

This lays the ground work for enabling casefolding and encryption at the
same time for ext4 and f2fs. A future set of patches will enable that
functionality.

These unify the highly similar dentry_operations that ext4 and f2fs both
use for casefolding. In addition, they improve d_hash by not requiring a
new string allocation.

Daniel Rosenberg (4):
  unicode: Add utf8_casefold_hash
  fs: Add standard casefolding support
  f2fs: Use generic casefolding support
  ext4: Use generic casefolding support

 fs/ext4/dir.c           | 64 +-----------------------------
 fs/ext4/ext4.h          | 12 ------
 fs/ext4/hash.c          |  2 +-
 fs/ext4/namei.c         | 20 ++++------
 fs/ext4/super.c         | 12 +++---
 fs/f2fs/dir.c           | 84 +++++----------------------------------
 fs/f2fs/f2fs.h          |  4 --
 fs/f2fs/super.c         | 10 ++---
 fs/f2fs/sysfs.c         | 10 +++--
 fs/libfs.c              | 87 +++++++++++++++++++++++++++++++++++++++++
 fs/unicode/utf8-core.c  | 23 ++++++++++-
 include/linux/f2fs_fs.h |  3 --
 include/linux/fs.h      | 16 ++++++++
 include/linux/unicode.h |  3 ++
 14 files changed, 165 insertions(+), 185 deletions(-)

Comments

Eric Biggers July 20, 2020, 5:09 p.m. UTC | #1

On Wed, Jul 08, 2020 at 02:12:33AM -0700, Daniel Rosenberg wrote:
> This lays the ground work for enabling casefolding and encryption at the
> same time for ext4 and f2fs. A future set of patches will enable that
> functionality.
> 
> These unify the highly similar dentry_operations that ext4 and f2fs both
> use for casefolding. In addition, they improve d_hash by not requiring a
> new string allocation.
> 
> Daniel Rosenberg (4):
>   unicode: Add utf8_casefold_hash
>   fs: Add standard casefolding support
>   f2fs: Use generic casefolding support
>   ext4: Use generic casefolding support
> 

Ted, are you interested in taking this through the ext4 tree for 5.9?

- Eric

Eric Biggers July 27, 2020, 4:45 p.m. UTC | #2

On Mon, Jul 20, 2020 at 10:09:51AM -0700, Eric Biggers wrote:
> On Wed, Jul 08, 2020 at 02:12:33AM -0700, Daniel Rosenberg wrote:
> > This lays the ground work for enabling casefolding and encryption at the
> > same time for ext4 and f2fs. A future set of patches will enable that
> > functionality.
> > 
> > These unify the highly similar dentry_operations that ext4 and f2fs both
> > use for casefolding. In addition, they improve d_hash by not requiring a
> > new string allocation.
> > 
> > Daniel Rosenberg (4):
> >   unicode: Add utf8_casefold_hash
> >   fs: Add standard casefolding support
> >   f2fs: Use generic casefolding support
> >   ext4: Use generic casefolding support
> > 
> 
> Ted, are you interested in taking this through the ext4 tree for 5.9?
> 
> - Eric

Ping?

Eric Biggers Aug. 24, 2020, 11 p.m. UTC | #3

On Mon, Jul 27, 2020 at 09:45:08AM -0700, Eric Biggers wrote:
> On Mon, Jul 20, 2020 at 10:09:51AM -0700, Eric Biggers wrote:
> > On Wed, Jul 08, 2020 at 02:12:33AM -0700, Daniel Rosenberg wrote:
> > > This lays the ground work for enabling casefolding and encryption at the
> > > same time for ext4 and f2fs. A future set of patches will enable that
> > > functionality.
> > > 
> > > These unify the highly similar dentry_operations that ext4 and f2fs both
> > > use for casefolding. In addition, they improve d_hash by not requiring a
> > > new string allocation.
> > > 
> > > Daniel Rosenberg (4):
> > >   unicode: Add utf8_casefold_hash
> > >   fs: Add standard casefolding support
> > >   f2fs: Use generic casefolding support
> > >   ext4: Use generic casefolding support
> > > 
> > 
> > Ted, are you interested in taking this through the ext4 tree for 5.9?
> > 
> > - Eric
> 
> Ping?
> 

Unfortunately this patchset got ignored for 5.9.

Ted, will you have any interest in taking this patchset for 5.10?  Or should
Jaegeuk just take patches 1-3 via the f2fs tree?

The fscrypt tree is also an option, but I feel it's not really appropriate since
this patchset is just a refactoring of the existing casefolding support.

More reviews on patches 1-2 would be appreciated too.  So far just Gabriel and I
have reviewed them.  I was hoping that other people would review them too.

- Eric

Jaegeuk Kim Aug. 24, 2020, 11:32 p.m. UTC | #4

On 08/24, Eric Biggers wrote:
> On Mon, Jul 27, 2020 at 09:45:08AM -0700, Eric Biggers wrote:
> > On Mon, Jul 20, 2020 at 10:09:51AM -0700, Eric Biggers wrote:
> > > On Wed, Jul 08, 2020 at 02:12:33AM -0700, Daniel Rosenberg wrote:
> > > > This lays the ground work for enabling casefolding and encryption at the
> > > > same time for ext4 and f2fs. A future set of patches will enable that
> > > > functionality.
> > > > 
> > > > These unify the highly similar dentry_operations that ext4 and f2fs both
> > > > use for casefolding. In addition, they improve d_hash by not requiring a
> > > > new string allocation.
> > > > 
> > > > Daniel Rosenberg (4):
> > > >   unicode: Add utf8_casefold_hash
> > > >   fs: Add standard casefolding support
> > > >   f2fs: Use generic casefolding support
> > > >   ext4: Use generic casefolding support
> > > > 
> > > 
> > > Ted, are you interested in taking this through the ext4 tree for 5.9?
> > > 
> > > - Eric
> > 
> > Ping?
> > 
> 
> Unfortunately this patchset got ignored for 5.9.
> 
> Ted, will you have any interest in taking this patchset for 5.10?  Or should
> Jaegeuk just take patches 1-3 via the f2fs tree?

fyi; I think I can merge 1-3, if Al has no concern on 1 & 2. 

> 
> The fscrypt tree is also an option, but I feel it's not really appropriate since
> this patchset is just a refactoring of the existing casefolding support.
> 
> More reviews on patches 1-2 would be appreciated too.  So far just Gabriel and I
> have reviewed them.  I was hoping that other people would review them too.
> 
> - Eric