| Message ID | 20200710031619.18762-1-justin.he@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix and enable pmem as RAM device on arm64 | expand |
On 10.07.20 05:16, Jia He wrote: > This fixies a few issues when I tried to enable pmem as RAM device on arm64. > > To use memory_add_physaddr_to_nid as a fallback nid, it would be better > implement a general version (__weak) in mm/memory_hotplug. After that, arm64/ > sh/s390 can simply use the general version, and PowerPC/ia64/x86 will use > arch specific version. > > Tested on ThunderX2 host/qemu "-M virt" guest with a nvdimm device. The > memblocks from the dax pmem device can be either hot-added or hot-removed > on arm64 guest. Also passed the compilation test on x86. > > Changes: > v4: - remove "device-dax: use fallback nid when numa_node is invalid", wait > for Dan Williams' phys_addr_to_target_node() patch So, this series no longer does what it promises? "Fix and enable pmem as RAM device on arm64"
Hi David > -----Original Message----- > From: David Hildenbrand <david@redhat.com> > Sent: Friday, July 10, 2020 4:30 PM > To: Justin He <Justin.He@arm.com>; Catalin Marinas > <Catalin.Marinas@arm.com>; Will Deacon <will@kernel.org>; Tony Luck > <tony.luck@intel.com>; Fenghua Yu <fenghua.yu@intel.com>; Yoshinori Sato > <ysato@users.sourceforge.jp>; Rich Felker <dalias@libc.org>; Dave Hansen > <dave.hansen@linux.intel.com>; Andy Lutomirski <luto@kernel.org>; Peter > Zijlstra <peterz@infradead.org>; Thomas Gleixner <tglx@linutronix.de>; > Ingo Molnar <mingo@redhat.com>; Borislav Petkov <bp@alien8.de> > Cc: x86@kernel.org; H. Peter Anvin <hpa@zytor.com>; Dan Williams > <dan.j.williams@intel.com>; Vishal Verma <vishal.l.verma@intel.com>; Dave > Jiang <dave.jiang@intel.com>; Andrew Morton <akpm@linux-foundation.org>; > Baoquan He <bhe@redhat.com>; Chuhong Yuan <hslester96@gmail.com>; Mike > Rapoport <rppt@linux.ibm.com>; Logan Gunthorpe <logang@deltatee.com>; > Masahiro Yamada <masahiroy@kernel.org>; Michal Hocko <mhocko@suse.com>; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux- > ia64@vger.kernel.org; linux-sh@vger.kernel.org; linux-nvdimm@lists.01.org; > linux-mm@kvack.org; Jonathan Cameron <Jonathan.Cameron@Huawei.com>; Kaly > Xin <Kaly.Xin@arm.com> > Subject: Re: [PATCH v4 0/2] Fix and enable pmem as RAM device on arm64 > > On 10.07.20 05:16, Jia He wrote: > > This fixies a few issues when I tried to enable pmem as RAM device on > arm64. > > > > To use memory_add_physaddr_to_nid as a fallback nid, it would be better > > implement a general version (__weak) in mm/memory_hotplug. After that, > arm64/ > > sh/s390 can simply use the general version, and PowerPC/ia64/x86 will > use > > arch specific version. > > > > Tested on ThunderX2 host/qemu "-M virt" guest with a nvdimm device. The > > memblocks from the dax pmem device can be either hot-added or hot- > removed > > on arm64 guest. Also passed the compilation test on x86. > > > > Changes: > > v4: - remove "device-dax: use fallback nid when numa_node is invalid", > wait > > for Dan Williams' phys_addr_to_target_node() patch > > So, this series no longer does what it promises? "Fix and enable pmem as > RAM device on arm64" > Hmm, a little bit awkward but seems no long what it promises. How about sending patch1 patch2 individually without this cover-letter? -- Cheers, Justin (Jia He)
On Thu, Jul 9, 2020 at 8:17 PM Jia He <justin.he@arm.com> wrote: > > This fixies a few issues when I tried to enable pmem as RAM device on arm64. > > To use memory_add_physaddr_to_nid as a fallback nid, it would be better > implement a general version (__weak) in mm/memory_hotplug. After that, arm64/ > sh/s390 can simply use the general version, and PowerPC/ia64/x86 will use > arch specific version. > > Tested on ThunderX2 host/qemu "-M virt" guest with a nvdimm device. The > memblocks from the dax pmem device can be either hot-added or hot-removed > on arm64 guest. Also passed the compilation test on x86. > > Changes: > v4: - remove "device-dax: use fallback nid when numa_node is invalid", wait > for Dan Williams' phys_addr_to_target_node() patch FWIW, I put these patches through a 0-day run overnight and will be posting them today.
This fixies a few issues when I tried to enable pmem as RAM device on arm64. To use memory_add_physaddr_to_nid as a fallback nid, it would be better implement a general version (__weak) in mm/memory_hotplug. After that, arm64/ sh/s390 can simply use the general version, and PowerPC/ia64/x86 will use arch specific version. Tested on ThunderX2 host/qemu "-M virt" guest with a nvdimm device. The memblocks from the dax pmem device can be either hot-added or hot-removed on arm64 guest. Also passed the compilation test on x86. Changes: v4: - remove "device-dax: use fallback nid when numa_node is invalid", wait for Dan Williams' phys_addr_to_target_node() patch - folder v3 patch1-4 into single one, no functional changes v3: https://lkml.org/lkml/2020/7/8/1541 - introduce general version memory_add_physaddr_to_nid, refine the arch specific one - fix an uninitialization bug in v2 device-dax patch v2: https://lkml.org/lkml/2020/7/7/71 - Drop unnecessary patch to harden try_offline_node - Use new solution(by David) to fix dev->target_node=-1 during probing - Refine the mem_hotplug_begin/done patch v1: https://lkml.org/lkml/2020/7/5/381 Jia He (2): mm/memory_hotplug: introduce default dummy memory_add_physaddr_to_nid() mm/memory_hotplug: fix unpaired mem_hotplug_begin/done arch/arm64/mm/numa.c | 10 ---------- arch/ia64/mm/numa.c | 2 -- arch/sh/mm/init.c | 9 --------- arch/x86/mm/numa.c | 1 - mm/memory_hotplug.c | 15 ++++++++++++--- 5 files changed, 12 insertions(+), 25 deletions(-)