mbox series

[rfc,0/6] blktests: Add support to run nvme tests with tcp/rdma transports

Message ID 20200803064835.67927-1-sagi@grimberg.me (mailing list archive)
Headers show
Series blktests: Add support to run nvme tests with tcp/rdma transports | expand

Message

Sagi Grimberg Aug. 3, 2020, 6:48 a.m. UTC 
We have a collection of nvme tests, but all run with nvme-loop. This
is the easiest to run on a standalone machine. However its very much possible
to run nvme-tcp and nvme-rdma using a loopback network. Add capability to run
tests with a new environment variable to set the transport type $nvme_trtype.

$ nvme_trtype=[loop|tcp|rdma] ./check test/nvme

This buys us some nice coverage on some more transport types. We also add
some transport type specific helpers to mark tests that are relevant only
for a single transport.

Sagi Grimberg (6):
  nvme: consolidate nvme requirements based on transport type
  nvme: consolidate some nvme-cli utility functions
  nvme: make tests transport type agnostic
  tests/nvme: restrict tests to specific transports
  nvme: support nvme-tcp when runinng tests
  nvme: support rdma transport type

 tests/nvme/002 |   8 ++--
 tests/nvme/003 |  10 ++--
 tests/nvme/004 |  12 +++--
 tests/nvme/005 |  15 +++---
 tests/nvme/006 |   7 +--
 tests/nvme/007 |   5 +-
 tests/nvme/008 |  13 +++---
 tests/nvme/009 |  11 +++--
 tests/nvme/010 |  13 +++---
 tests/nvme/011 |  13 +++---
 tests/nvme/012 |  14 +++---
 tests/nvme/013 |  13 +++---
 tests/nvme/014 |  13 +++---
 tests/nvme/015 |  12 +++--
 tests/nvme/016 |   7 +--
 tests/nvme/017 |   7 +--
 tests/nvme/018 |  13 +++---
 tests/nvme/019 |  13 +++---
 tests/nvme/020 |  11 +++--
 tests/nvme/021 |  13 +++---
 tests/nvme/022 |  13 +++---
 tests/nvme/023 |  13 +++---
 tests/nvme/024 |  13 +++---
 tests/nvme/025 |  13 +++---
 tests/nvme/026 |  13 +++---
 tests/nvme/027 |  13 +++---
 tests/nvme/028 |  15 +++---
 tests/nvme/029 |  13 +++---
 tests/nvme/030 |   8 ++--
 tests/nvme/031 |  12 ++---
 tests/nvme/032 |   4 ++
 tests/nvme/rc  | 122 +++++++++++++++++++++++++++++++++++++++++++++----
 32 files changed, 309 insertions(+), 166 deletions(-)

Comments

Chaitanya Kulkarni Aug. 3, 2020, 8:16 p.m. UTC | #1 
On 8/2/20 23:48, Sagi Grimberg wrote:
> We have a collection of nvme tests, but all run with nvme-loop. This
> is the easiest to run on a standalone machine. However its very much possible
> to run nvme-tcp and nvme-rdma using a loopback network. Add capability to run
> tests with a new environment variable to set the transport type $nvme_trtype.
> 
> $ nvme_trtype=[loop|tcp|rdma] ./check test/nvme
> 
> This buys us some nice coverage on some more transport types. We also add
> some transport type specific helpers to mark tests that are relevant only
> for a single transport.

Thanks for having this done, overall approach looks good to me.

We can get rid of the rfc title and start the reviews.
Sagi Grimberg Aug. 4, 2020, 3:37 p.m. UTC | #2 
>> We have a collection of nvme tests, but all run with nvme-loop. This
>> is the easiest to run on a standalone machine. However its very much possible
>> to run nvme-tcp and nvme-rdma using a loopback network. Add capability to run
>> tests with a new environment variable to set the transport type $nvme_trtype.
>>
>> $ nvme_trtype=[loop|tcp|rdma] ./check test/nvme
>>
>> This buys us some nice coverage on some more transport types. We also add
>> some transport type specific helpers to mark tests that are relevant only
>> for a single transport.
> 
> Thanks for having this done, overall approach looks good to me.
> 
> We can get rid of the rfc title and start the reviews.

Next send will not have RFC, but review can start with this set.