diff mbox

configure.ac: allow '--with-convert=' to accept comma-separated values

Message ID 20171012120854.28748-1-slyfox@gentoo.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sergei Trofimovich Oct. 12, 2017, 12:08 p.m. UTC
Before the change configure refused to accept it's defaults explicitly:
    $ ./configure --enable-convert --with-convert=ext2,reiserfs
    ...
    configure: error: unknown tokens for --with-convert: ,

After the change both converters are enabled:
    $ ./configure --enable-convert --with-convert=ext2,reiserfs
    ...
            btrfs-convert:      yes (ext2,reiserfs)

Cc: linux-btrfs@vger.kernel.org
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba Oct. 12, 2017, 12:30 p.m. UTC | #1
On Thu, Oct 12, 2017 at 01:08:54PM +0100, Sergei Trofimovich wrote:
> Before the change configure refused to accept it's defaults explicitly:
>     $ ./configure --enable-convert --with-convert=ext2,reiserfs
>     ...
>     configure: error: unknown tokens for --with-convert: ,
> 
> After the change both converters are enabled:
>     $ ./configure --enable-convert --with-convert=ext2,reiserfs
>     ...
>             btrfs-convert:      yes (ext2,reiserfs)
> 
> Cc: linux-btrfs@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index f273bbe9..adceafc3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@  AC_SUBST([BTRFSCONVERT_EXT2])
 AC_SUBST([BTRFSCONVERT_REISERFS])
 
 # catch typos
-tmp=$(echo "$with_convert" | sed -e 's/auto//' | sed -e 's/ext2//' | sed -e 's/reiserfs//' | sed -e 's/,\+/,/')
+tmp=$(echo "$with_convert" | sed -e 's/auto//' | sed -e 's/ext2//' | sed -e 's/reiserfs//' | sed -e 's/,\+//')
 if ! test "x$tmp" = "x"; then
 	AC_MSG_ERROR([unknown tokens for --with-convert: $tmp])
 fi