Patchwork crypto: cavium: clean up clang warning on unread variable offset

login
register
mail settings
Submitter Colin Ian King
Date Oct. 12, 2017, 4:44 p.m.
Message ID <20171012164406.31934-1-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/10002391/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Colin Ian King - Oct. 12, 2017, 4:44 p.m.
From: Colin Ian King <colin.king@canonical.com>

The variable offset is being assigned and not being used; it should
be passed as the 2nd argument to call to function nitrox_write_csr
but has been omitted. Fix this.

Cleans up clang warning: Value stored to 'offset' is never read

Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/crypto/cavium/nitrox/nitrox_hal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Herbert Xu - Nov. 3, 2017, 2:22 p.m.
On Thu, Oct 12, 2017 at 05:44:06PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable offset is being assigned and not being used; it should
> be passed as the 2nd argument to call to function nitrox_write_csr
> but has been omitted. Fix this.
> 
> Cleans up clang warning: Value stored to 'offset' is never read
> 
> Fixes: 14fa93cdcd9b ("crypto: cavium - Add support for CNN55XX adapters.")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.

Patch

diff --git a/drivers/crypto/cavium/nitrox/nitrox_hal.c b/drivers/crypto/cavium/nitrox/nitrox_hal.c
index f0655f82fa7d..73275ce6a668 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_hal.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_hal.c
@@ -126,7 +126,7 @@  void nitrox_config_pkt_input_rings(struct nitrox_device *ndev)
 		 * size and interrupt threshold.
 		 */
 		offset = NPS_PKT_IN_INSTR_BADDRX(i);
-		nitrox_write_csr(ndev, NPS_PKT_IN_INSTR_BADDRX(i), cmdq->dma);
+		nitrox_write_csr(ndev, offset, cmdq->dma);
 
 		/* configure ring size */
 		offset = NPS_PKT_IN_INSTR_RSIZEX(i);