Patchwork crypto: qat: remove unused and redundant pointer vf_info

login
register
mail settings
Submitter Colin Ian King
Date Oct. 12, 2017, 5:04 p.m.
Message ID <20171012170456.32505-1-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/10002415/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Colin Ian King - Oct. 12, 2017, 5:04 p.m.
From: Colin Ian King <colin.king@canonical.com>

The pointer vf_info is being assigned but never read, it is redundant
and therefore can be removed.

Cleans up clang warning: Value stored to 'vf_info' is never read

Fixes: ed8ccaef52fa ("crypto: qat - Add support for SRIOV")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/crypto/qat/qat_common/adf_dev_mgr.c | 3 ---
 1 file changed, 3 deletions(-)
Herbert Xu - Nov. 3, 2017, 2:23 p.m.
On Thu, Oct 12, 2017 at 06:04:56PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The pointer vf_info is being assigned but never read, it is redundant
> and therefore can be removed.
> 
> Cleans up clang warning: Value stored to 'vf_info' is never read
> 
> Fixes: ed8ccaef52fa ("crypto: qat - Add support for SRIOV")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Patch applied.  Thanks.

Patch

diff --git a/drivers/crypto/qat/qat_common/adf_dev_mgr.c b/drivers/crypto/qat/qat_common/adf_dev_mgr.c
index 8afac52677a6..2d06409bd3c4 100644
--- a/drivers/crypto/qat/qat_common/adf_dev_mgr.c
+++ b/drivers/crypto/qat/qat_common/adf_dev_mgr.c
@@ -228,11 +228,8 @@  int adf_devmgr_add_dev(struct adf_accel_dev *accel_dev,
 		list_add_tail(&map->list, &vfs_table);
 	} else if (accel_dev->is_vf && pf) {
 		/* VF on host */
-		struct adf_accel_vf_info *vf_info;
 		struct vf_id_map *map;
 
-		vf_info = pf->pf.vf_info + adf_get_vf_id(accel_dev);
-
 		map = adf_find_vf(adf_get_vf_num(accel_dev));
 		if (map) {
 			struct vf_id_map *next;