From patchwork Fri Oct 13 09:11:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10003855 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E612E60325 for ; Fri, 13 Oct 2017 09:11:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D940628FFE for ; Fri, 13 Oct 2017 09:11:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC42E29005; Fri, 13 Oct 2017 09:11:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D62D228FFE for ; Fri, 13 Oct 2017 09:11:58 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 42D7626766A; Fri, 13 Oct 2017 11:11:56 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BD2EE26766C; Fri, 13 Oct 2017 11:11:54 +0200 (CEST) Received: from relmlie4.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by alsa0.perex.cz (Postfix) with ESMTP id 04F1A266EE0 for ; Fri, 13 Oct 2017 11:11:48 +0200 (CEST) Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie4.idc.renesas.com with ESMTP; 13 Oct 2017 18:11:45 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 8091878D77; Fri, 13 Oct 2017 18:11:45 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.43,370,1503327600"; d="scan'208";a="260433421" Received: from mail-sg2apc01lp0239.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.239]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 13 Oct 2017 18:11:44 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ocDAuRU1BrrheX/1I6/bq31mPXUUeWh69xyHGSeNorU=; b=Ut+88KVXew7WP4QtLzSdCJtcJ5coFhlwIyTlkOlQp1px7pc+2FdAjB21DVgWDqOGIUH5QUbpE8zt15uHHo96vXSJJf2+nPHKp+QYTblKtLP8myaZgLSLhN6BLSCywKw86/CAvN761LVKDgskc3aM+QQqIrLQEEoHN6NEwNqVmNU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.138) by HK2PR0601MB1876.apcprd06.prod.outlook.com (2603:1096:202:a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Fri, 13 Oct 2017 09:11:42 +0000 Message-ID: <87efq7v2qf.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Takashi Iwai In-Reply-To: References: <20171011101618.8736-1-tiwai@suse.de> <87fuanv70u.wl%kuninori.morimoto.gx@renesas.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 13 Oct 2017 09:11:42 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: SG2PR0401CA0020.apcprd04.prod.outlook.com (2603:1096:3:1::30) To HK2PR0601MB1876.apcprd06.prod.outlook.com (2603:1096:202:a::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59775cf9-3c09-4c63-f12d-08d5121a6bee X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:HK2PR0601MB1876; X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 3:6I+PzIB1mzNAOSozsZj++GcgWl2BJY3OPATRUbJOGcJKFSX6n3AToz7nfCRTYIxCj38OAqM4mwVTQXoZEMzIuPLUo29vkvVzAisVCjJrUpPSefoQLqVyKb4Badg/KcNf+hlA1Hy+Lmo4ChvTVvJ9ndlpBIPq6+nDMF1Hb1DrCSt/7mgGLFJHuhgf8Zk1qeo7Tra9SvpNvKI+ESmPxxJL3VaT5g1JpWkulaVEIQ0+VPJoqi+mJZQDiw7W27FyGMiv; 25:pQUUVCUwyupSx43AbUL2BJsNyg7uKVCTk389sN3zDeFutfLZq6osf+tqxL/zkbJRy0UWa7TCxFMpu1K24wGaEpJRr5/AzLTVNAUqhswGcjYH4zLHPe4S+r+/Ftwjx2Tp06N+kI824QI3qcEcy5LmTO36YwNGpKm7wpOMOzPb3gfs7RMKCtAq2fBU5TxwzQcc7LAfY6v1j3LSC7Y7XtgpYK8tUm6d0KBBLtptZnUkR7an+BHSVdczeRA37xxdNEaQO26BeOjyfWO4aB1TnLUsNjgTP864I9i+ZQUzTZNNDAFjaVxyFjLFJfzbtwagtxqYci0WbitsbAwsiwjNsNlcRA==; 31:6OIYwGaGNwoUw0tIK8L0squd1uZNbmvVvGkPUXG5VjBcgogqa53G1qkMIvvkHxIUmu01gntW3BHREPUgPP8Vlw+RERaTcb1nXwu+u+GxTuq7JaOpQvjO9xzoHVzsRSovNMMdpC/blI4FxvDO/TBXs++ASef3sa7NhrNfbYP/KUwCb1/zBQ5mXObvPVmKGYmfzVOAY2TCbLpJ0GM2cynE5/O47KBRqzOBkHO2JiFqivc= X-MS-TrafficTypeDiagnostic: HK2PR0601MB1876: X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 20:7avRAkbqB5h6k8mr2Jultl4bc9UyclIDYDGfli/HG6iB7/vlo2R36rcT2ikMyKl2Y+tyRx2ve1fm1XNZwwnptZ2ExMSPgRaKXQpc7xKNA23q53cgdTMjo5TW9hqwTGvTofvWnk6booiMbMpsojBFeP1NNDMyVlSX84rWxyHMVpv+YyGyOEAJJiCQcpXOF+FHZGptoPBHnEcvXgqcyyZ7kgrkbusKj2i7BbvSig7wTnTcjaRQhXLbVJNc0fSmugpjtFboIZ+DFBp4ve+pck+k0xSSq5Lmq2Z/3aDRddO4+FOwUmfjafssP9cJ7XJQXmebJsQZ503gbnaM1cZdUfXeUpehMbkMP8ShURakWyxpT5jOVkeyA1aRGGCrj4X66eQDiODFanKNnIiQe1v/3lY0sROTfOs35Soch48JL+6hvQANNBrfpq80CHD6TrZH/xijpS1VgqPTKKWjjolyaZS3yjnfYM+b9mbqQMsqBH5sExvXot7VVZddbuJkuEDaEMK/; 4:y9UibDOgNL2b/Kg6bkdNF46HAdTEs8aSPqTcbfesW+GRXSuyVTAAd5c+JukeB0eliTac3hqw0OpCInDIOsgj+yhlOjMtPl8E3J2Hl+Tr5SOoKdpO5ZsC8Hi/Lz9WLD0FOO+clwYIYnru4tWc4kxlrLXfkoMeR2uVRsdKk9F6ifqbnt3TEWffOLguUIjnG7CUf8k6Yzt+MysFb+U1dZuWaG3gh58VsiRCzS3aGLUu5ye7hyY4SxWJ/TjgV7o7lq/m X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HK2PR0601MB1876; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HK2PR0601MB1876; X-Forefront-PRVS: 04599F3534 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(346002)(376002)(39860400002)(199003)(189002)(68736007)(106356001)(53416004)(2906002)(16586007)(6246003)(316002)(58126008)(105586002)(53936002)(5660300001)(76176999)(101416001)(50986999)(478600001)(69596002)(54356999)(23726003)(6916009)(47776003)(16526018)(97736004)(305945005)(6116002)(25786009)(4326008)(2950100002)(86362001)(189998001)(36756003)(54906003)(50466002)(33646002)(8676002)(229853002)(6486002)(8936002)(83506001)(66066001)(3846002)(7736002)(81156014)(81166006)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:HK2PR0601MB1876; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HK2PR0601MB1876; 23:1Ei1V9jlTiWGbiaqAFJLUBaqUWXA1rxvWEqzXAy?= =?us-ascii?Q?AWLKJSM8iLDm3Noy1ZzRkj9TeI+4VdYyztgZ942fjon1QXAr8PvdL/0ZOWIG?= =?us-ascii?Q?RdIVGE/GKnK8KOfu/tBtprCULS/hZ5z4j0fdLSGLHOn/E1+0KjW/dO83XkL/?= =?us-ascii?Q?ja2354Ryszv7+WLG9PIuaq07RNmVUDWOo1vvh9flm9/bXjFi1zReOhaHcL4W?= =?us-ascii?Q?RKyEBO1JkqNy4AdqiKd4MjEgYYoFUdpcFJK4Me4nRpIgHQltP3pskw1EznSQ?= =?us-ascii?Q?Pfbm0Yh/Hc5q1CBa1aJTmp5KYd3J/6o5mB+CcjFBWuEvAV+ne0JpPjiAUqhi?= =?us-ascii?Q?pmFXMeN5QpLqTybhgq1i17Nc2Ppg4Wk1UUwqW18to8LM3YkhlbUIVhNKyRoZ?= =?us-ascii?Q?S8hi8dNUOhO6DiM3RqPKYr5oRhbp6PGLEzOydmKM0d9+OYTYOuFhuxn/rhYf?= =?us-ascii?Q?mVeRKmxBWDv/aqLXWYPbGTriRqr7o/kJKAoWO9TpBOskfZIMfRwwFW9Fi2F1?= =?us-ascii?Q?w4zTj7+nSqO6JX+K1zwPyCUXA5VuEWNTLlUVJrKuFjB5X8rF4pO+0oadmtzF?= =?us-ascii?Q?77aah5rdBbEDKXh1MjneM8Qz809NRP/fxpgX/PxCfohNDmc4ufK1SAYZ+bi2?= =?us-ascii?Q?CscBMvXd9zmixmYZEl/Ns10P6DD9s17nm6xEQQNleEK0wtTe44ck8/60BXCP?= =?us-ascii?Q?1cN+ch0sGH7JkXL4HRLtti5LgYLNkI61Ir0308DAcnVOUkrss730OmERPOqr?= =?us-ascii?Q?+eh1QRjtkPHowLlPNKNkqys6pd+i8+OixVR+RrCy1OGZGRE6uIdqfWQSxdKj?= =?us-ascii?Q?fth28wK+VtNrmluUTIbOXt0M5ef/W0E0whf2aQIK0B71ldqRXt+BGwEJ+zKP?= =?us-ascii?Q?E8aCsM5OTxLmexXSyzymzWTefRT5qgrDTgTwR7eRXyygUWw9etoPXhFIsK4P?= =?us-ascii?Q?nvexzHqbCWcpv1ZYc+87fTynRmfbZ9iP7EvvvcFEKqZmvz/P2tJpHl9UdF6F?= =?us-ascii?Q?qMTraQPNX/jr2Rq/RMgIe78fu+uxIJ8X+eMxA+nUDzu+AmD8iinNgpelAjFg?= =?us-ascii?Q?pn+E1RgdtMTMdvXtXUTy91WnBCEq0XrSQgymzfbbT2Ksco2kJBCaAxirskkT?= =?us-ascii?Q?JnPQAPi9o2xg5pb1bHm01FZXxGTJBYi61ihFXYdv6TsuRY/O0x36dIGfvAPL?= =?us-ascii?Q?KHVDZxMDbFECbU6M=3D?= X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 6:57fGbxtpueCWkMbffOw5QAGzyTyvfQ+viha/O3Geyz1Ca2ci23rv9qCuDuSFf8RkZw7NwkoaAQGM34r24MNPIe1fsVJMBxJTxMGiD4bWV6DVSU3W4r5sqoZk2251MHfFzkKPkwG+1YZgk0UynNfZVrA+nLIYRjRAWJlqrJMnC+8dxgEOVEyNLsaX+9yLJctNRpTW+Fzdxr8w5xdrvwDYEnnQuDimct2DZo7515Di6luXf2Q0ARd3alKMIacJltUhN4PXS+9JevmV8pfB1a3rhm777JcEjEixiE9YdCY/742qXFUuyQVzNZtzT74LPs4WpX/0///etk2m6fFWtcqvjA==; 5:A0d2QP5tNqMYFh8M04okQET3nIMC+VBni3+rAvD8N3AiciCxebcXQq36wocO9I+4b/VTNq/TVUlQZsWUT5tJcqCXPlCaMe6l6LGguGIMhaq5cDFVrVkuyMbwgnA7DRa5Asn653iqLKNLi865v5enEg==; 24:K+iWmsZ8/gkbr794WeGkvwvm+xN75CMe4pKQ2fCYO4gV/8Rwo5MDXZnlI9XqIs/gWJovMnOvIPmBrMsOSuS5YSdhcQFeGfC4Z/9Jok39BMM=; 7:Y4WfsKpyeoU0S6tN9WWKYlqOT0oxT5YYDKCWd/zUND98BVsV7jMn/hv0Fcv0WO+IeznJewx+x5EOc0IUvrfQyARVhOwO/HOpum0rmRrCvW3YZyO1d6QcJb9rstL5rouIvqkZf1KUu3nv8OJ7YbdjkgrrllqCvhruU4iHNmz1WkXcebjwc7nG0ADAqpwDabmp9Ub9PoTv9TwGj8CODE47TXhRoV8TqSuh6jnsl8rJTh0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HK2PR0601MB1876; 20:sGA2Q+JrdTPdsk1B8iaLo8KeYIgNbS1IeEEQ8rfANvMQjG5T3qxb6ob/V2h426XFuZ4lEjUQl8nVURwFZ2iWsSyYwttJr4TdI/Oweugfepo6dz5yMhFHZ9wuKXuLSZgFSY57glwHboTPbZXQgG6QS1nYndLoR2Qo6q23gsXi83c= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2017 09:11:42.4720 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2PR0601MB1876 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: Re: [alsa-devel] [PATCH v2 0/2] Add snd_card_disconnect_sync() helper X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Takashi > > I tested this patch-set. > > I noticed that it doesn't work if I used DPCM > > (Kernel has Oops). > > I will investigate it next week > > Could you show the Oops message if you have? > My concern is whether it happens by stopping at disconnect, or it's > just another missing piece. OK, but kernel log doesn't help you. see below My environment now is I'm using DPCM. FE : rsnd FE : rsnd BE : ak4613 1st issue is that kernel need below patch. I guess BE is using dummy driver, and it doesn't have ops(?). If this is needed, I can post it. ----------------------- After this patch, my driver side clock counter mismatch Oops happen. It seems this is because FE side wasn't called snd_pcm_stop(); (= BE side only called snd_pcm_stop()). I could confirm this by printing who's stop was called by local quick hack. Maybe timing reason, if kernel has Oops for some reasons, then, both BE/FE snd_pcm_stop() are called. If no Oops, BE snd_pcm_stop() only called. Best regards --- Kuninori Morimoto diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 2fec2fe..972408b 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -1241,7 +1241,8 @@ static int snd_pcm_do_stop(struct snd_pcm_substream *substream, int state) { if (substream->runtime->trigger_master == substream && snd_pcm_running(substream)) - substream->ops->trigger(substream, SNDRV_PCM_TRIGGER_STOP); + if (substream->ops && substream->ops->trigger) + substream->ops->trigger(substream, SNDRV_PCM_TRIGGER_STOP); return 0; /* unconditonally stop all substreams */ } -----------------------