Patchwork [01/48] drm: omapdrm: dpi: Don't treat GPIO probe deferral as an error

login
register
mail settings
Submitter Laurent Pinchart
Date Oct. 13, 2017, 2:58 p.m.
Message ID <20171013145944.26557-2-laurent.pinchart@ideasonboard.com>
Download mbox | patch
Permalink /patch/10004957/
State New
Headers show

Comments

Laurent Pinchart - Oct. 13, 2017, 2:58 p.m.
There's no need to print an error message on probe deferral, that's a
normal situation. Probe deferral debugging can be performed by enabling
the related debug messages in the drivers core.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Sebastian Reichel - Oct. 14, 2017, 12:11 p.m.
Hi,

On Fri, Oct 13, 2017 at 05:58:57PM +0300, Laurent Pinchart wrote:
> There's no need to print an error message on probe deferral, that's a
> normal situation. Probe deferral debugging can be performed by enabling
> the related debug messages in the drivers core.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> index 947295f9e30f..b8e420c7d680 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> @@ -173,7 +173,8 @@ static int tfp410_probe_of(struct platform_device *pdev)
>  	if (gpio_is_valid(gpio) || gpio == -ENOENT) {
>  		ddata->pd_gpio = gpio;
>  	} else {
> -		dev_err(&pdev->dev, "failed to parse PD gpio\n");
> +		if (gpio != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to parse PD gpio\n");
>  		return gpio;
>  	}

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

Patch

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
index 947295f9e30f..b8e420c7d680 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
@@ -173,7 +173,8 @@  static int tfp410_probe_of(struct platform_device *pdev)
 	if (gpio_is_valid(gpio) || gpio == -ENOENT) {
 		ddata->pd_gpio = gpio;
 	} else {
-		dev_err(&pdev->dev, "failed to parse PD gpio\n");
+		if (gpio != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "failed to parse PD gpio\n");
 		return gpio;
 	}