[07/48] drm: omapdrm: dpi: Remove dpi_data port_initialized field
diff mbox

Message ID 20171013145944.26557-8-laurent.pinchart@ideasonboard.com
State New
Headers show

Commit Message

Laurent Pinchart Oct. 13, 2017, 2:59 p.m. UTC
The dpi_data structure port_initialized field is used to check in the
cleanup path whether the DPI has been initialized. This can be performed
through the associated device_node data field instead. Remove the
port_initialized field.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/omapdrm/dss/dpi.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Sebastian Reichel Oct. 14, 2017, 12:28 p.m. UTC | #1
Hi,

On Fri, Oct 13, 2017 at 05:59:03PM +0300, Laurent Pinchart wrote:
> The dpi_data structure port_initialized field is used to check in the
> cleanup path whether the DPI has been initialized. This can be performed
> through the associated device_node data field instead. Remove the
> port_initialized field.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

>  drivers/gpu/drm/omapdrm/dss/dpi.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c
> index daf286fc8a40..ce9b27978f48 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dpi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
> @@ -52,8 +52,6 @@ struct dpi_data {
>  	int data_lines;
>  
>  	struct omap_dss_device output;
> -
> -	bool port_initialized;
>  };
>  
>  static struct dpi_data *dpi_get_data_from_dssdev(struct omap_dss_device *dssdev)
> @@ -786,8 +784,6 @@ int dpi_init_port(struct platform_device *pdev, struct device_node *port,
>  
>  	dpi_init_output_port(dpi, port);
>  
> -	dpi->port_initialized = true;
> -
>  	return 0;
>  
>  err_datalines:
> @@ -800,7 +796,7 @@ void dpi_uninit_port(struct device_node *port)
>  {
>  	struct dpi_data *dpi = port->data;
>  
> -	if (!dpi->port_initialized)
> +	if (!dpi)
>  		return;
>  
>  	dpi_uninit_output_port(port);
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch
diff mbox

diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c b/drivers/gpu/drm/omapdrm/dss/dpi.c
index daf286fc8a40..ce9b27978f48 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
@@ -52,8 +52,6 @@  struct dpi_data {
 	int data_lines;
 
 	struct omap_dss_device output;
-
-	bool port_initialized;
 };
 
 static struct dpi_data *dpi_get_data_from_dssdev(struct omap_dss_device *dssdev)
@@ -786,8 +784,6 @@  int dpi_init_port(struct platform_device *pdev, struct device_node *port,
 
 	dpi_init_output_port(dpi, port);
 
-	dpi->port_initialized = true;
-
 	return 0;
 
 err_datalines:
@@ -800,7 +796,7 @@  void dpi_uninit_port(struct device_node *port)
 {
 	struct dpi_data *dpi = port->data;
 
-	if (!dpi->port_initialized)
+	if (!dpi)
 		return;
 
 	dpi_uninit_output_port(port);