Patchwork [29/48] drm: omapdrm: dss: Remove dss_get_hdmi_venc_clk_source() function

login
register
mail settings
Submitter Laurent Pinchart
Date Oct. 13, 2017, 2:59 p.m.
Message ID <20171013145944.26557-30-laurent.pinchart@ideasonboard.com>
Download mbox | patch
Permalink /patch/10005045/
State New
Headers show

Comments

Laurent Pinchart - Oct. 13, 2017, 2:59 p.m.
The function is unused, remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/omapdrm/dss/dss.c | 14 --------------
 drivers/gpu/drm/omapdrm/dss/dss.h |  1 -
 2 files changed, 15 deletions(-)
Sebastian Reichel - Oct. 16, 2017, 9:16 a.m.
Hi,

On Fri, Oct 13, 2017 at 05:59:25PM +0300, Laurent Pinchart wrote:
> The function is unused, remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

>  drivers/gpu/drm/omapdrm/dss/dss.c | 14 --------------
>  drivers/gpu/drm/omapdrm/dss/dss.h |  1 -
>  2 files changed, 15 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
> index 98a0da32f217..8b83bdcde6e2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -775,20 +775,6 @@ void dss_select_hdmi_venc_clk_source(struct dss_device *dss,
>  		REG_FLD_MOD(DSS_CONTROL, src, 15, 15);	/* VENC_HDMI_SWITCH */
>  }
>  
> -enum dss_hdmi_venc_clk_source_select dss_get_hdmi_venc_clk_source(void)
> -{
> -	enum omap_dss_output_id outputs;
> -
> -	outputs = dss.feat->outputs[OMAP_DSS_CHANNEL_DIGIT];
> -	if ((outputs & OMAP_DSS_OUTPUT_HDMI) == 0)
> -		return DSS_VENC_TV_CLK;
> -
> -	if ((outputs & OMAP_DSS_OUTPUT_VENC) == 0)
> -		return DSS_HDMI_M_PCLK;
> -
> -	return REG_GET(DSS_CONTROL, 15, 15);
> -}
> -
>  static int dss_dpi_select_source_omap2_omap3(struct dss_device *dss, int port,
>  					     enum omap_channel channel)
>  {
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h b/drivers/gpu/drm/omapdrm/dss/dss.h
> index 2641d5c6a32a..6950f5d61b6c 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.h
> @@ -292,7 +292,6 @@ int dss_dpi_select_source(struct dss_device *dss, int port,
>  			  enum omap_channel channel);
>  void dss_select_hdmi_venc_clk_source(struct dss_device *dss,
>  				     enum dss_hdmi_venc_clk_source_select src);
> -enum dss_hdmi_venc_clk_source_select dss_get_hdmi_venc_clk_source(void);
>  const char *dss_get_clk_source_name(enum dss_clk_source clk_src);
>  
>  /* DSS VIDEO PLL */
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Patch

diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c b/drivers/gpu/drm/omapdrm/dss/dss.c
index 98a0da32f217..8b83bdcde6e2 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.c
+++ b/drivers/gpu/drm/omapdrm/dss/dss.c
@@ -775,20 +775,6 @@  void dss_select_hdmi_venc_clk_source(struct dss_device *dss,
 		REG_FLD_MOD(DSS_CONTROL, src, 15, 15);	/* VENC_HDMI_SWITCH */
 }
 
-enum dss_hdmi_venc_clk_source_select dss_get_hdmi_venc_clk_source(void)
-{
-	enum omap_dss_output_id outputs;
-
-	outputs = dss.feat->outputs[OMAP_DSS_CHANNEL_DIGIT];
-	if ((outputs & OMAP_DSS_OUTPUT_HDMI) == 0)
-		return DSS_VENC_TV_CLK;
-
-	if ((outputs & OMAP_DSS_OUTPUT_VENC) == 0)
-		return DSS_HDMI_M_PCLK;
-
-	return REG_GET(DSS_CONTROL, 15, 15);
-}
-
 static int dss_dpi_select_source_omap2_omap3(struct dss_device *dss, int port,
 					     enum omap_channel channel)
 {
diff --git a/drivers/gpu/drm/omapdrm/dss/dss.h b/drivers/gpu/drm/omapdrm/dss/dss.h
index 2641d5c6a32a..6950f5d61b6c 100644
--- a/drivers/gpu/drm/omapdrm/dss/dss.h
+++ b/drivers/gpu/drm/omapdrm/dss/dss.h
@@ -292,7 +292,6 @@  int dss_dpi_select_source(struct dss_device *dss, int port,
 			  enum omap_channel channel);
 void dss_select_hdmi_venc_clk_source(struct dss_device *dss,
 				     enum dss_hdmi_venc_clk_source_select src);
-enum dss_hdmi_venc_clk_source_select dss_get_hdmi_venc_clk_source(void);
 const char *dss_get_clk_source_name(enum dss_clk_source clk_src);
 
 /* DSS VIDEO PLL */