diff mbox

[3/3] drm/edid: quirk HTC vive headset as non-standard.

Message ID 20171016042909.6901-3-airlied@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dave Airlie Oct. 16, 2017, 4:29 a.m. UTC
From: Dave Airlie <airlied@redhat.com>

This uses the EDID info from my HTC Vive to mark it as
non-standard.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/drm_edid.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thierry Reding Oct. 16, 2017, 6:47 a.m. UTC | #1
On Mon, Oct 16, 2017 at 02:29:09PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> This uses the EDID info from my HTC Vive to mark it as
> non-standard.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
>  drivers/gpu/drm/drm_edid.c | 3 +++
>  1 file changed, 3 insertions(+)

I guess I was being naive for thinking that HMDs would come with a
special EDID extension. Google indicates that someone might have worked
on something called HMD-EXT to be standardized by VESA for EDID, but no
documents seem to exist for that.

Thierry
Pierre-Loup A. Griffais Oct. 17, 2017, 12:59 a.m. UTC | #2
On 10/15/2017 11:47 PM, Thierry Reding wrote:
> On Mon, Oct 16, 2017 at 02:29:09PM +1000, Dave Airlie wrote:
>> From: Dave Airlie <airlied@redhat.com>
>>
>> This uses the EDID info from my HTC Vive to mark it as
>> non-standard.
>>
>> Signed-off-by: Dave Airlie <airlied@redhat.com>
>> ---
>>   drivers/gpu/drm/drm_edid.c | 3 +++
>>   1 file changed, 3 insertions(+)
> 
> I guess I was being naive for thinking that HMDs would come with a
> special EDID extension. Google indicates that someone might have worked
> on something called HMD-EXT to be standardized by VESA for EDID, but no
> documents seem to exist for that.

We had someone working with VESA on exactly that and I thought that had 
shipped, but we found the same thing: the extension was never released 
and there's not currently a standard way to tag HMDs at the EDID-level, 
which is very unfortunate, as you'd want the lowest levels of the system 
to be aware of the HMD-ness of a display. You would never want to bring 
up a text console on one, or any sort of non-distorted content. I'll 
look into getting that effort back on track, but in the meantime it 
looks like an EDID blacklist somewhere might be our best bet.

Thanks,
  - Pierre-Loup


> 
> Thierry
> 
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 4225052def37..b491b3c3cc1f 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -159,6 +159,9 @@  static const struct edid_quirk {
 
 	/* Rotel RSX-1058 forwards sink's EDID but only does HDMI 1.1*/
 	{ "ETR", 13896, EDID_QUIRK_FORCE_8BPC },
+
+	/* HTC Vive VR Headset */
+	{ "HVR", 0xaa01, EDID_QUIRK_NON_STD_DEVICE },
 };
 
 /*