| Message ID | CALFpzo4Nc3y1zps9tct5BMjHa2kYSEQyPpK=66XSRtLK7WqzBA@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 22 Jul 2011, Marcus Sorensen wrote: > auth/Crypto.cc:218: error: expected primary-expression before ?}? token > auth/Crypto.cc:218: error: expected ?;? before ?}? token > > Perhaps something more is missing here but this gets things going... > apparently not used much? Looks right. Maybe only some compiler versions bork on that? We also usually build with crypto++ when we can (libnss sucks a several ways). Can I add your signed-off-by? Thanks- sage > --- > src/auth/Crypto.cc | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/auth/Crypto.cc b/src/auth/Crypto.cc > index 7251d09..ad256bb 100644 > --- a/src/auth/Crypto.cc > +++ b/src/auth/Crypto.cc > @@ -215,6 +215,7 @@ static void nss_aes_operation(CK_ATTRIBUTE_TYPE > op, const bufferptr& secret, > err_slot: > PK11_FreeSlot(slot); > err: > + ; > } > > #else > -- > 1.7.4.1 > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >
Yeah, sorry. This was a CentOS 6 system, didn't seem to have any immediate provider of libcrypto++, so just skipped to nss. I figured that not many people are probably using the nss path, so I'm not sure if this is just untested or something wonky on the compiler... at any rate an extra semicolon shouldn't break others :-) On Fri, Jul 22, 2011 at 2:25 PM, Sage Weil <sage@newdream.net> wrote: > On Fri, 22 Jul 2011, Marcus Sorensen wrote: >> auth/Crypto.cc:218: error: expected primary-expression before ?}? token >> auth/Crypto.cc:218: error: expected ?;? before ?}? token >> >> Perhaps something more is missing here but this gets things going... >> apparently not used much? > > Looks right. Maybe only some compiler versions bork on that? We > also usually build with crypto++ when we can (libnss sucks a > several ways). > > Can I add your signed-off-by? > > Thanks- > sage > > >> --- >> src/auth/Crypto.cc | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/src/auth/Crypto.cc b/src/auth/Crypto.cc >> index 7251d09..ad256bb 100644 >> --- a/src/auth/Crypto.cc >> +++ b/src/auth/Crypto.cc >> @@ -215,6 +215,7 @@ static void nss_aes_operation(CK_ATTRIBUTE_TYPE >> op, const bufferptr& secret, >> err_slot: >> PK11_FreeSlot(slot); >> err: >> + ; >> } >> >> #else >> -- >> 1.7.4.1 >> -- >> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> -- To unsubscribe from this list: send the line "unsubscribe ceph-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/auth/Crypto.cc b/src/auth/Crypto.cc index 7251d09..ad256bb 100644 --- a/src/auth/Crypto.cc +++ b/src/auth/Crypto.cc @@ -215,6 +215,7 @@ static void nss_aes_operation(CK_ATTRIBUTE_TYPE op, const bufferptr& secret, err_slot: PK11_FreeSlot(slot); err: + ; }