| Message ID | 20171019112610.13645-4-mbrugger@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 2017-10-19 at 13:26 +0200, Matthias Brugger wrote: > DRM subysystem and clock driver shared the same compatible mmsys. > This stopped does not work, as only the first driver for a compatible > gets probed. We change the comaptible to the new DRM identifier to fix > this. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index b99a27372965..89db0a3f5950 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -803,6 +803,11 @@ > #clock-cells = <1>; > }; > > + dispsys: display-system { > + compatible = "mediatek,mt2701-dispsys"; Same comment as for patch 1, I'd prefer the node to be called "display- subsystem" instead. With that changed, Acked-by: Philipp Zabel <p.zabel@pengutronix.de> > + mediatek,mmsys = <&mmsys>; > + } > + > mdp_rdma0: rdma@14001000 { > compatible = "mediatek,mt8173-mdp-rdma", > "mediatek,mt8173-mdp"; regards Philipp
Hi, Matthias: On Thu, 2017-10-19 at 13:26 +0200, Matthias Brugger wrote: > DRM subysystem and clock driver shared the same compatible mmsys. > This stopped does not work, as only the first driver for a compatible > gets probed. We change the comaptible to the new DRM identifier to fix > this. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index b99a27372965..89db0a3f5950 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -803,6 +803,11 @@ > #clock-cells = <1>; > }; > > + dispsys: display-system { > + compatible = "mediatek,mt2701-dispsys"; Why do you probe "mediatek,mt2701-dispsys" in mt8173.dtsi? Regards, CK > + mediatek,mmsys = <&mmsys>; > + } > + > mdp_rdma0: rdma@14001000 { > compatible = "mediatek,mt8173-mdp-rdma", > "mediatek,mt8173-mdp";
On 10/20/2017 11:16 AM, CK Hu wrote: > Hi, Matthias: > > On Thu, 2017-10-19 at 13:26 +0200, Matthias Brugger wrote: >> DRM subysystem and clock driver shared the same compatible mmsys. >> This stopped does not work, as only the first driver for a compatible >> gets probed. We change the comaptible to the new DRM identifier to fix >> this. >> >> Signed-off-by: Matthias Brugger <mbrugger@suse.com> >> --- >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> index b99a27372965..89db0a3f5950 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi >> @@ -803,6 +803,11 @@ >> #clock-cells = <1>; >> }; >> >> + dispsys: display-system { >> + compatible = "mediatek,mt2701-dispsys"; > > Why do you probe "mediatek,mt2701-dispsys" in mt8173.dtsi? > That's actually a copy-paste-error. Thanks for noting! Matthias > Regards, > CK > >> + mediatek,mmsys = <&mmsys>; >> + } >> + >> mdp_rdma0: rdma@14001000 { >> compatible = "mediatek,mt8173-mdp-rdma", >> "mediatek,mt8173-mdp"; > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index b99a27372965..89db0a3f5950 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi @@ -803,6 +803,11 @@ #clock-cells = <1>; }; + dispsys: display-system { + compatible = "mediatek,mt2701-dispsys"; + mediatek,mmsys = <&mmsys>; + } + mdp_rdma0: rdma@14001000 { compatible = "mediatek,mt8173-mdp-rdma", "mediatek,mt8173-mdp";
DRM subysystem and clock driver shared the same compatible mmsys. This stopped does not work, as only the first driver for a compatible gets probed. We change the comaptible to the new DRM identifier to fix this. Signed-off-by: Matthias Brugger <mbrugger@suse.com> --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 5 +++++ 1 file changed, 5 insertions(+)