btrfs-progs: ins: fix arg order in print_inode_item()
diff mbox

Message ID 91513913-9626-da65-5830-b372895f1325@jp.fujitsu.com
State New
Headers show

Commit Message

Misono Tomohiro Oct. 30, 2017, 8:10 a.m. UTC
In the print_inode_item(), the argument order of sequence and flags are
reversed:

printf("... sequence %llu flags 0x%llx(%s)\n",
				... 
	       (unsigned long long)btrfs_inode_flags(eb,ii),
 	       (unsigned long long)btrfs_inode_sequence(eb, ii),
				...)

So, just fix it.

Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
---
 print-tree.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Qu Wenruo Oct. 30, 2017, 8:20 a.m. UTC | #1
On 2017年10月30日 16:10, Misono, Tomohiro wrote:
> In the print_inode_item(), the argument order of sequence and flags are
> reversed:
> 
> printf("... sequence %llu flags 0x%llx(%s)\n",
> 				... 
> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
> 				...)
> 
> So, just fix it.
> 
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>  print-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/print-tree.c b/print-tree.c
> index 3c585e3..8abd760 100644
> --- a/print-tree.c
> +++ b/print-tree.c
> @@ -896,8 +896,8 @@ static void print_inode_item(struct extent_buffer *eb,
>  	       btrfs_inode_uid(eb, ii),
>  	       btrfs_inode_gid(eb, ii),
>  	       (unsigned long long)btrfs_inode_rdev(eb,ii),
> -	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
> +	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       flags_str);
>  	print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
>  	print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");
>
Qu Wenruo Oct. 30, 2017, 8:39 a.m. UTC | #2
On 2017年10月30日 16:10, Misono, Tomohiro wrote:
> In the print_inode_item(), the argument order of sequence and flags are
> reversed:
> 
> printf("... sequence %llu flags 0x%llx(%s)\n",
> 				... 
> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
> 				...)
> 
> So, just fix it.

Not related to this patch, but considering you're going to enhance
root_item creation, it's also a good idea to print such info like
c/o/s/r time and parent/receive UUID.

More patches will never be a bad thing.

Thanks,
Qu
> 
> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
> ---
>  print-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/print-tree.c b/print-tree.c
> index 3c585e3..8abd760 100644
> --- a/print-tree.c
> +++ b/print-tree.c
> @@ -896,8 +896,8 @@ static void print_inode_item(struct extent_buffer *eb,
>  	       btrfs_inode_uid(eb, ii),
>  	       btrfs_inode_gid(eb, ii),
>  	       (unsigned long long)btrfs_inode_rdev(eb,ii),
> -	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
> +	       (unsigned long long)btrfs_inode_flags(eb,ii),
>  	       flags_str);
>  	print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
>  	print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");
>
Misono Tomohiro Oct. 31, 2017, 3 a.m. UTC | #3
On 2017/10/30 17:39, Qu Wenruo wrote:
> 
> 
> On 2017年10月30日 16:10, Misono, Tomohiro wrote:
>> In the print_inode_item(), the argument order of sequence and flags are
>> reversed:
>>
>> printf("... sequence %llu flags 0x%llx(%s)\n",
>> 				... 
>> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> 				...)
>>
>> So, just fix it.
> 
> Not related to this patch, but considering you're going to enhance
> root_item creation, it's also a good idea to print such info like
> c/o/s/r time and parent/receive UUID.
> 
> More patches will never be a bad thing.

Actually parent/received UUID is printed if it exists but c/o/s/r time is not
(for ROOT_ITEM). So, I will send a patch.

Thanks,
Tomohiro 


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Qu Wenruo Jan. 16, 2018, 4:32 a.m. UTC | #4
Hi David,

Would you please queue this patch to devel branch?

This is a small enough, but quite important fix when handling dump tree
output.

Thanks,
Qu

On 2017年10月30日 16:20, Qu Wenruo wrote:
> 
> 
> On 2017年10月30日 16:10, Misono, Tomohiro wrote:
>> In the print_inode_item(), the argument order of sequence and flags are
>> reversed:
>>
>> printf("... sequence %llu flags 0x%llx(%s)\n",
>> 				... 
>> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> 				...)
>>
>> So, just fix it.
>>
>> Signed-off-by: Tomohiro Misono <misono.tomohiro@jp.fujitsu.com>
> 
> Reviewed-by: Qu Wenruo <wqu@suse.com>
> 
> Thanks,
> Qu
> 
>> ---
>>  print-tree.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/print-tree.c b/print-tree.c
>> index 3c585e3..8abd760 100644
>> --- a/print-tree.c
>> +++ b/print-tree.c
>> @@ -896,8 +896,8 @@ static void print_inode_item(struct extent_buffer *eb,
>>  	       btrfs_inode_uid(eb, ii),
>>  	       btrfs_inode_gid(eb, ii),
>>  	       (unsigned long long)btrfs_inode_rdev(eb,ii),
>> -	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> +	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       flags_str);
>>  	print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
>>  	print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");
>>
>

Patch
diff mbox

diff --git a/print-tree.c b/print-tree.c
index 3c585e3..8abd760 100644
--- a/print-tree.c
+++ b/print-tree.c
@@ -896,8 +896,8 @@  static void print_inode_item(struct extent_buffer *eb,
 	       btrfs_inode_uid(eb, ii),
 	       btrfs_inode_gid(eb, ii),
 	       (unsigned long long)btrfs_inode_rdev(eb,ii),
-	       (unsigned long long)btrfs_inode_flags(eb,ii),
 	       (unsigned long long)btrfs_inode_sequence(eb, ii),
+	       (unsigned long long)btrfs_inode_flags(eb,ii),
 	       flags_str);
 	print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
 	print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");