drm/TODO: Clarify DRM_DEV_* conversion
diff mbox

Message ID 20171030131536.11654-1-daniel.vetter@ffwll.ch
State New
Headers show

Commit Message

Daniel Vetter Oct. 30, 2017, 1:15 p.m. UTC
Not everyone agrees this is the best thing, so make it really clear
that maintainers need to be asked first, then the conversion. We've
had a few newbies that did this the other way round, got their patches
rejected, which isn't the best newbie experience.

Cc: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 Documentation/gpu/todo.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Sean Paul Oct. 30, 2017, 4:07 p.m. UTC | #1
On Mon, Oct 30, 2017 at 9:15 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Not everyone agrees this is the best thing, so make it really clear
> that maintainers need to be asked first, then the conversion. We've
> had a few newbies that did this the other way round, got their patches
> rejected, which isn't the best newbie experience.
>
> Cc: Sean Paul <seanpaul@chromium.org>

Acked-by: Sean Paul <seanpaul@chromium.org>

> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  Documentation/gpu/todo.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 96f8ec7dbe4e..e9840d693a86 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -179,6 +179,10 @@ don't do this, drivers used dev_info/warn/err to make this differentiation. We
>  now have DRM_DEV_* variants of the drm print macros, so we can start to convert
>  those drivers back to using drm-formwatted specific log messages.
>
> +Before you start this conversion please contact the relevant maintainers to make
> +sure your work will be merged - not everyone agrees that the DRM dmesg macros
> +are better.
> +
>  Contact: Sean Paul, Maintainer of the driver you plan to convert
>
>  Core refactorings
> --
> 2.15.0.rc1
>

Patch
diff mbox

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 96f8ec7dbe4e..e9840d693a86 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -179,6 +179,10 @@  don't do this, drivers used dev_info/warn/err to make this differentiation. We
 now have DRM_DEV_* variants of the drm print macros, so we can start to convert
 those drivers back to using drm-formwatted specific log messages.
 
+Before you start this conversion please contact the relevant maintainers to make
+sure your work will be merged - not everyone agrees that the DRM dmesg macros
+are better.
+
 Contact: Sean Paul, Maintainer of the driver you plan to convert
 
 Core refactorings