diff mbox

drm: mali-dp: Disable planes when their CRTC gets disabled.

Message ID 20171101141326.3112-1-Liviu.Dudau@arm.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liviu Dudau Nov. 1, 2017, 2:13 p.m. UTC 
Make sure only the planes on the active CRTCs get committed and
that all planes on the disabled CRTCs get turned off.

Reviewed-by: Brian Starkey <brian.starkey@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
---
 drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Gustavo Padovan Nov. 15, 2017, 7:25 p.m. UTC | #1 
Hi Liviu,

2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:

> Make sure only the planes on the active CRTCs get committed and
> that all planes on the disabled CRTCs get turned off.
> 
> Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Gustavo
Liviu Dudau Nov. 15, 2017, 10:35 p.m. UTC | #2 
On Wed, Nov 15, 2017 at 05:25:02PM -0200, Gustavo Padovan wrote:
> Hi Liviu,

Hi Gustavo,

> 
> 2017-11-01 Liviu Dudau <Liviu.Dudau@arm.com>:
> 
> > Make sure only the planes on the active CRTCs get committed and
> > that all planes on the disabled CRTCs get turned off.
> > 
> > Reviewed-by: Brian Starkey <brian.starkey@arm.com>
> > Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
> > ---
> >  drivers/gpu/drm/arm/malidp_crtc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>

Thanks for reviewing both patches!

Best regards,
Liviu

> 
> Gustavo
diff mbox

Patch

diff --git a/drivers/gpu/drm/arm/malidp_crtc.c b/drivers/gpu/drm/arm/malidp_crtc.c
index 153a496706262..904fff80917ba 100644
--- a/drivers/gpu/drm/arm/malidp_crtc.c
+++ b/drivers/gpu/drm/arm/malidp_crtc.c
@@ -77,6 +77,9 @@  static void malidp_crtc_atomic_disable(struct drm_crtc *crtc,
 	struct malidp_hw_device *hwdev = malidp->dev;
 	int err;
 
+	/* always disable planes on the CRTC that is being turned off */
+	drm_atomic_helper_disable_planes_on_crtc(old_state, false);
+
 	drm_crtc_vblank_off(crtc);
 	hwdev->hw->enter_config_mode(hwdev);