| Message ID | 20171108212505.28320-5-afd@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 2017-11-08 at 15:25 -0600, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpio", fix this here. > > Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board") > > Signed-off-by: Andrew F. Davis <afd@ti.com> > --- > arch/arm/boot/dts/am335x-pepper.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts > index 03c7d77023c6..d652abd76333 100644 > --- a/arch/arm/boot/dts/am335x-pepper.dts > +++ b/arch/arm/boot/dts/am335x-pepper.dts > @@ -139,7 +139,7 @@ > &audio_codec { > status = "okay"; > > - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>; > + reset-gpio = <&gpio1 16 GPIO_ACTIVE_LOW>; This potentially breaks audio on am335x-pepper until the driver patches are applied, same for the other device trees. To make this bisectable, add support for the new property name to the driver before changing the device trees. regards Philipp
On 11/09/2017 08:25 AM, Philipp Zabel wrote: > On Wed, 2017-11-08 at 15:25 -0600, Andrew F. Davis wrote: >> The correct DT property for specifying a GPIO used for reset >> is "reset-gpio", fix this here. >> >> Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board") >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> >> --- >> arch/arm/boot/dts/am335x-pepper.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts >> index 03c7d77023c6..d652abd76333 100644 >> --- a/arch/arm/boot/dts/am335x-pepper.dts >> +++ b/arch/arm/boot/dts/am335x-pepper.dts >> @@ -139,7 +139,7 @@ >> &audio_codec { >> status = "okay"; >> >> - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>; >> + reset-gpio = <&gpio1 16 GPIO_ACTIVE_LOW>; > > This potentially breaks audio on am335x-pepper until the driver patches > are applied, same for the other device trees. To make this bisectable, > add support for the new property name to the driver before changing the > device trees. AFAIK this change doesn't break anything as this reset was not used in a functional way (it was just pulled high in probe if provided, but the pin_mux and/or and on-board resistor should have done the same already, but a series I just posted will actually get some use out of it and so I want to get this fixed before then). As controversial as it may be, my plan is to simply not support the old binding at all, supporting it would add unnecessary bloat to the driver, prevent moving to new frameworks that expect the correct binding (fwnode_get_named_gpiod), and in this case provide no benefit as far as I can tell. Andrew > > regards > Philipp >
diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts index 03c7d77023c6..d652abd76333 100644 --- a/arch/arm/boot/dts/am335x-pepper.dts +++ b/arch/arm/boot/dts/am335x-pepper.dts @@ -139,7 +139,7 @@ &audio_codec { status = "okay"; - gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>; + reset-gpio = <&gpio1 16 GPIO_ACTIVE_LOW>; AVDD-supply = <&ldo3_reg>; IOVDD-supply = <&ldo3_reg>; DRVDD-supply = <&ldo3_reg>;
The correct DT property for specifying a GPIO used for reset is "reset-gpio", fix this here. Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board") Signed-off-by: Andrew F. Davis <afd@ti.com> --- arch/arm/boot/dts/am335x-pepper.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)