diff mbox

drm/i915/dmc: DMC 1.04 for Kabylake

Message ID 1510253503-12634-1-git-send-email-anusha.srivatsa@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Srivatsa, Anusha Nov. 9, 2017, 6:51 p.m. UTC
There is a new version of DMC available for KBL.

The release notes mentions:
1. Fix for the issue where DC_STATE was getting enabled even
when disabled by driver causing data corruption.

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/intel_csr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Rodrigo Vivi Nov. 9, 2017, 7:53 p.m. UTC | #1
On Thu, Nov 09, 2017 at 06:51:43PM +0000, Anusha Srivatsa wrote:
> There is a new version of DMC available for KBL.
> 
> The release notes mentions:
> 1. Fix for the issue where DC_STATE was getting enabled even
> when disabled by driver causing data corruption.

v2: Remove pull request from commit message (Rodrigo).

> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Since this got tested by CI already I'm going to merge as soon as
I see the pull request flowing to linux-firmware.git.

But I also hope linux-firmware.git gets faster in accepting
our pull requests...

Thanks,
Rodrigo.

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 77d8b3d..07e4f7b 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -40,9 +40,9 @@
>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>  
> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>  MODULE_FIRMWARE(I915_CSR_KBL);
> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>  
>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>  MODULE_FIRMWARE(I915_CSR_SKL);
> -- 
> 2.7.4
>
Jani Nikula Nov. 23, 2017, 9:16 a.m. UTC | #2
On Thu, 09 Nov 2017, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Thu, Nov 09, 2017 at 06:51:43PM +0000, Anusha Srivatsa wrote:
>> There is a new version of DMC available for KBL.
>> 
>> The release notes mentions:
>> 1. Fix for the issue where DC_STATE was getting enabled even
>> when disabled by driver causing data corruption.
>
> v2: Remove pull request from commit message (Rodrigo).
>
>> 
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Since this got tested by CI already I'm going to merge as soon as
> I see the pull request flowing to linux-firmware.git.

Pushed, thanks for the patch and review.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=cb12249bf495460abf9945c8a8bf2a13a07c235a

BR,
Jani.

>
> But I also hope linux-firmware.git gets faster in accepting
> our pull requests...
>
> Thanks,
> Rodrigo.
>
>> ---
>>  drivers/gpu/drm/i915/intel_csr.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
>> index 77d8b3d..07e4f7b 100644
>> --- a/drivers/gpu/drm/i915/intel_csr.c
>> +++ b/drivers/gpu/drm/i915/intel_csr.c
>> @@ -40,9 +40,9 @@
>>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
>>  #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
>>  
>> -#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
>> +#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
>>  MODULE_FIRMWARE(I915_CSR_KBL);
>> -#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
>> +#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
>>  
>>  #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
>>  MODULE_FIRMWARE(I915_CSR_SKL);
>> -- 
>> 2.7.4
>> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 77d8b3d..07e4f7b 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -40,9 +40,9 @@ 
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_06.bin"
 #define CNL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 6)
 
-#define I915_CSR_KBL "i915/kbl_dmc_ver1_01.bin"
+#define I915_CSR_KBL "i915/kbl_dmc_ver1_04.bin"
 MODULE_FIRMWARE(I915_CSR_KBL);
-#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 1)
+#define KBL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 4)
 
 #define I915_CSR_SKL "i915/skl_dmc_ver1_26.bin"
 MODULE_FIRMWARE(I915_CSR_SKL);