From patchwork Tue May 18 20:13:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liam Girdwood X-Patchwork-Id: 100597 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.3) with ESMTP id o4IKDwAm020842 for ; Tue, 18 May 2010 20:13:58 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757923Ab0ERUN4 (ORCPT ); Tue, 18 May 2010 16:13:56 -0400 Received: from mail-ww0-f46.google.com ([74.125.82.46]:39291 "EHLO mail-ww0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806Ab0ERUNz (ORCPT ); Tue, 18 May 2010 16:13:55 -0400 Received: by mail-ww0-f46.google.com with SMTP id 22so61884wwb.19 for ; Tue, 18 May 2010 13:13:55 -0700 (PDT) Received: by 10.227.142.21 with SMTP id o21mr6751054wbu.187.1274213634690; Tue, 18 May 2010 13:13:54 -0700 (PDT) Received: from localhost.localdomain (host81-136-218-57.in-addr.btopenworld.com [81.136.218.57]) by mx.google.com with ESMTPS id l23sm50762912wbb.8.2010.05.18.13.13.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 18 May 2010 13:13:53 -0700 (PDT) From: Liam Girdwood To: , Cc: Liam Girdwood , Mark Brown , Peter Ujfalusi , Jarkko Nikula , Tony Lindgren Subject: [PATCH 4/4] OMAP: mcbsp - remove sysfs set for DMA op mode. Date: Tue, 18 May 2010 21:13:14 +0100 Message-Id: <1274213594-26554-5-git-send-email-lrg@slimlogic.co.uk> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1274213594-26554-1-git-send-email-lrg@slimlogic.co.uk> References: <1274213594-26554-1-git-send-email-lrg@slimlogic.co.uk> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter.kernel.org [140.211.167.41]); Tue, 18 May 2010 20:13:58 +0000 (UTC) diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index 7785050..b7b8b5e 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -1546,35 +1546,7 @@ static ssize_t dma_op_mode_show(struct device *dev, return len; } -static ssize_t dma_op_mode_store(struct device *dev, - struct device_attribute *attr, - const char *buf, size_t size) -{ - struct omap_mcbsp *mcbsp = dev_get_drvdata(dev); - const char * const *s; - int i = 0; - - for (s = &dma_op_modes[i]; i < ARRAY_SIZE(dma_op_modes); s++, i++) - if (sysfs_streq(buf, *s)) - break; - - if (i == ARRAY_SIZE(dma_op_modes)) - return -EINVAL; - - spin_lock_irq(&mcbsp->lock); - if (!mcbsp->free) { - size = -EBUSY; - goto unlock; - } - mcbsp->dma_op_mode = i; - -unlock: - spin_unlock_irq(&mcbsp->lock); - - return size; -} - -static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store); +static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, NULL); static ssize_t st_taps_show(struct device *dev, struct device_attribute *attr, char *buf)