Message ID | 7b5b034c-e441-f363-a94f-c81bd0b5ed7a@users.sourceforge.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, 16 Nov 2017 12:52:41 +0100, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Thu, 16 Nov 2017 11:22:26 +0100 > > The function "release_firmware" is called in the current implementation of > the function "_request_firmware" after a failure was detected. > Link: https://elixir.free-electrons.com/linux/v4.14-rc8/source/drivers/base/firmware_class.c#L1196 > > Such a call should therefore not be repeated directly after the > corresponding error information was received in the local variable "err" > of the function "snd_korg1212_create". > Thus remove a misplaced function call. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied, thanks. Takashi
diff --git a/sound/pci/korg1212/korg1212.c b/sound/pci/korg1212/korg1212.c index 6dde8c215b48..dc701519d219 100644 --- a/sound/pci/korg1212/korg1212.c +++ b/sound/pci/korg1212/korg1212.c @@ -2352,7 +2352,6 @@ static int snd_korg1212_create(struct snd_card *card, struct pci_dev *pci, err = request_firmware(&dsp_code, "korg/k1212.dsp", &pci->dev); if (err < 0) { - release_firmware(dsp_code); snd_printk(KERN_ERR "firmware not available\n"); snd_korg1212_free(korg1212); return err;