[GIT,PULL] gvt-next for 4.16
diff mbox

Message ID 20171117020251.iy6ymzoj6vzto5ik@zhen-hp.sh.intel.com
State New
Headers show

Commit Message

Zhenyu Wang Nov. 17, 2017, 2:02 a.m. UTC
On 2017.11.16 12:20:14 -0800, Rodrigo Vivi wrote:
> Hi Zhenyu,
> 
> On Thu, Nov 16, 2017 at 09:20:07AM +0000, Zhenyu Wang wrote:
> > 
> > Hi,
> > 
> > As we missed 4.15 cycle, here's the bigger initial 4.16 gvt-next pull,
> > which includes many improvements as noted below.
> > 
> > thanks
> > 
> > --
> > The following changes since commit 34cc9efc27e2623c76a69d2ad1fa2b972e27a2c1:
> > 
> >   drm/i915: Remove pre-production pooled-EU w/a for Broxton (2017-11-15 18:04:18 +0000)
> > 
> > are available in the Git repository at:
> 
> this capital "G" broke dim here... It took me a while to figure out what
> was going wrong.
> 
> How did you generate this pull request? Why this "g" is in capital?
>

I'm using git 2.15-rc2, so found below one.

commit e66d7c37a5f123f1dcede06ac0e11f9254c3ef46
Author: Ann T Ropea <bedhanger@gmx.de>
Date:   Tue Oct 3 00:08:38 2017 +0000

    request-pull: capitalise "Git" to make it a proper noun

    Of the many ways to spell the three-letter word, the variant "Git"
        should be used when referring to a repository in a description; or, in
	    general, when it is used as a proper noun.

    We thus change the pull-request template message so that it reads

       "...in the Git repository at:"

    Besides, this brings us in line with the documentation, see
        Documentation/howto/using-signed-tag-in-pull-request.txt

    Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
    Acked-by: Jonathan Nieder <jrnieder@gmail.com>
    Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>



> Anyway I workarounded it here and pulled your changes into dinq.
>

thanks!

Comments

Rodrigo Vivi Nov. 17, 2017, 5:42 p.m. UTC | #1
On Fri, Nov 17, 2017 at 02:02:51AM +0000, Zhenyu Wang wrote:
> On 2017.11.16 12:20:14 -0800, Rodrigo Vivi wrote:
> > Hi Zhenyu,
> > 
> > On Thu, Nov 16, 2017 at 09:20:07AM +0000, Zhenyu Wang wrote:
> > > 
> > > Hi,
> > > 
> > > As we missed 4.15 cycle, here's the bigger initial 4.16 gvt-next pull,
> > > which includes many improvements as noted below.
> > > 
> > > thanks
> > > 
> > > --
> > > The following changes since commit 34cc9efc27e2623c76a69d2ad1fa2b972e27a2c1:
> > > 
> > >   drm/i915: Remove pre-production pooled-EU w/a for Broxton (2017-11-15 18:04:18 +0000)
> > > 
> > > are available in the Git repository at:
> > 
> > this capital "G" broke dim here... It took me a while to figure out what
> > was going wrong.
> > 
> > How did you generate this pull request? Why this "g" is in capital?
> >
> 
> I'm using git 2.15-rc2, so found below one.
> 
> commit e66d7c37a5f123f1dcede06ac0e11f9254c3ef46
> Author: Ann T Ropea <bedhanger@gmx.de>
> Date:   Tue Oct 3 00:08:38 2017 +0000
> 
>     request-pull: capitalise "Git" to make it a proper noun
> 
>     Of the many ways to spell the three-letter word, the variant "Git"
>         should be used when referring to a repository in a description; or, in
> 	    general, when it is used as a proper noun.
> 
>     We thus change the pull-request template message so that it reads
> 
>        "...in the Git repository at:"
> 
>     Besides, this brings us in line with the documentation, see
>         Documentation/howto/using-signed-tag-in-pull-request.txt
> 
>     Signed-off-by: Ann T Ropea <bedhanger@gmx.de>
>     Acked-by: Jonathan Nieder <jrnieder@gmail.com>
>     Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>     Signed-off-by: Junio C Hamano <gitster@pobox.com>
> 
> diff --git a/git-request-pull.sh b/git-request-pull.sh
> index eebd33276da9..13c172bd94fc 100755
> --- a/git-request-pull.sh
> +++ b/git-request-pull.sh
> @@ -128,7 +128,7 @@ git show -s --format='The following changes since commit %H:
> 
>    %s (%ci)
> 
> -are available in the git repository at:
> +are available in the Git repository at:

Thanks for the explanation and for finding this source.
Jani already to care of dinq so we should be fine now on ;)

Thanks,
Rodrigo.

>  ' $merge_base &&
>   echo "  $url $pretty_remote" &&
>    git show -s --format='
> 
> 
> > Anyway I workarounded it here and pulled your changes into dinq.
> >
> 
> thanks!
> 
> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

Patch
diff mbox

diff --git a/git-request-pull.sh b/git-request-pull.sh
index eebd33276da9..13c172bd94fc 100755
--- a/git-request-pull.sh
+++ b/git-request-pull.sh
@@ -128,7 +128,7 @@  git show -s --format='The following changes since commit %H:

   %s (%ci)

-are available in the git repository at:
+are available in the Git repository at:
 ' $merge_base &&
  echo "  $url $pretty_remote" &&
   git show -s --format='