From patchwork Fri Nov 17 17:44:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goldwyn Rodrigues X-Patchwork-Id: 10063053 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8FABD6023A for ; Fri, 17 Nov 2017 17:45:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E8BC2AD16 for ; Fri, 17 Nov 2017 17:45:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 737C82AD3A; Fri, 17 Nov 2017 17:45:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 012FF2AD16 for ; Fri, 17 Nov 2017 17:45:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161113AbdKQRpe (ORCPT ); Fri, 17 Nov 2017 12:45:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:34924 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161106AbdKQRpX (ORCPT ); Fri, 17 Nov 2017 12:45:23 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D1A78ABFC for ; Fri, 17 Nov 2017 17:45:21 +0000 (UTC) From: Goldwyn Rodrigues To: linux-btrfs@vger.kernel.org Cc: Goldwyn Rodrigues Subject: [RFC PATCH 8/8] iomap: Introduce iomap->dirty_page() Date: Fri, 17 Nov 2017 11:44:56 -0600 Message-Id: <20171117174456.13393-11-rgoldwyn@suse.de> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171117174456.13393-1-rgoldwyn@suse.de> References: <20171117174456.13393-1-rgoldwyn@suse.de> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Goldwyn Rodrigues In dirty_page(), we are clearing PageChecked, though I don't see it set. Is this used for compression only? Can we call __set_page_dirty_nobuffers instead? Signed-off-by: Goldwyn Rodrigues --- fs/btrfs/file.c | 8 ++++++++ fs/iomap.c | 2 ++ include/linux/iomap.h | 1 + 3 files changed, 11 insertions(+) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 1c459c9001b2..ba304e782098 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -1648,10 +1648,18 @@ static void btrfs_file_process_page(struct inode *inode, struct page *page) get_page(page); } +static void btrfs_file_dirty_page(struct page *page) +{ + SetPageUptodate(page); + ClearPageChecked(page); + set_page_dirty(page); +} + const struct iomap_ops btrfs_iomap_ops = { .iomap_begin = btrfs_file_iomap_begin, .iomap_end = btrfs_file_iomap_end, .iomap_process_page = btrfs_file_process_page, + .iomap_dirty_page = btrfs_file_dirty_page, }; static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb, diff --git a/fs/iomap.c b/fs/iomap.c index a32660b1b6c5..0907790c76c0 100644 --- a/fs/iomap.c +++ b/fs/iomap.c @@ -208,6 +208,8 @@ iomap_write_actor(struct inode *inode, loff_t pos, loff_t length, void *data, status = iomap_write_end(inode, pos, bytes, copied, page, iomap); if (unlikely(status < 0)) break; + if (ops->iomap_dirty_page) + ops->iomap_dirty_page(page); copied = status; cond_resched(); diff --git a/include/linux/iomap.h b/include/linux/iomap.h index fbb0194d56d6..7fbf6889dc54 100644 --- a/include/linux/iomap.h +++ b/include/linux/iomap.h @@ -76,6 +76,7 @@ struct iomap_ops { ssize_t written, unsigned flags, struct iomap *iomap); void (*iomap_process_page)(struct inode *inode, struct page *page); + void (*iomap_dirty_page)(struct page *page); }; ssize_t iomap_file_buffered_write(struct kiocb *iocb, struct iov_iter *from,