From patchwork Fri Nov 17 19:15:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10063435 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1C7EF6037E for ; Fri, 17 Nov 2017 19:17:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0CC4C2ACC5 for ; Fri, 17 Nov 2017 19:17:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 01AD32AD99; Fri, 17 Nov 2017 19:17:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B36CA2ACC5 for ; Fri, 17 Nov 2017 19:17:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966343AbdKQTRE (ORCPT ); Fri, 17 Nov 2017 14:17:04 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33930 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161646AbdKQTQ2 (ORCPT ); Fri, 17 Nov 2017 14:16:28 -0500 Received: by mail-pg0-f65.google.com with SMTP id 4so2625269pge.1; Fri, 17 Nov 2017 11:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ASG9T7+F/Gr9sN+ZDZNrA0iYQDBnVeL0+7Vz3CFwyOA=; b=m5y0NuWIlWg/bzXZg3vIKzULEMcAjKmjdrJanJ0axwjTdkoM0ZGwZ1yjOyWR1zWHBp jClkX9ekljzCqnfTiRdZN3YERCFFEkJV3SsQ587kH/M1iMI7UiLYr2g0FWNsIYPF7DIw lCenwAjIe8/MEGOVaEuvvQVKSR+pAeR4q/6NtYhMstEjh58cGtPtrZ++n3DDiegpNnLG a/ABf4A9+BrC0wzpF+1AN1AK28ba0BAHsL7FbKbyDT5ELPAFMHlpxH7Jwb7ySyFHIjaT 5GuJPHLLUUJmCbDW4TzjJ1qZT4uY+9HNbuKWaLbOF80pEbgoieAQwqQmRyELFcrSWRqd W+JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ASG9T7+F/Gr9sN+ZDZNrA0iYQDBnVeL0+7Vz3CFwyOA=; b=AGAnjJCkTqNHGnbn1hHZi0s5FX/HTOCvRjaRB6B2/v/25L+RYMfwniDbnnO/+lJ6wk 2XT3I04ipgHdpZhF6Z875UFI2OTIE+VDyrTvQVcvQEXh+EtNvOX5YR94+P/uMf41OvzI C0oGp9OeC24RIuoFVHOZCjy3LhACV9iF+PoGTHiNPV/18jPrvuH3r8sWmWF3ygoTznT5 Qr6he7DLxWZr6hSLZB1uR5k9OL4ditFuVRtRYBPjAfFqT7hgQSgfPwcB4hB3BNr/ZIwJ FEvqN1XospERzWyG45j3KGW6xokDWjkLTpfv9BnDEhQwfI4QwXP4jRzbkU1CRklH76UK 4D3A== X-Gm-Message-State: AJaThX6EPBRsKJ7jiZaYEbS3LL0bRddl0BXImTYCcZH/4UN1bHVqqJbX 7wSse0w0CJS4kTp+MFaM35o= X-Google-Smtp-Source: AGs4zMZTU46Lb6hdipfpKb0fJNo7zSOS6+6ATNXIQVX32+RphdoAwd3BmTYUAKk/R1bP9H5T5/0P2g== X-Received: by 10.84.179.194 with SMTP id b60mr6332728plc.275.1510946187613; Fri, 17 Nov 2017 11:16:27 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id u188sm7807441pfb.188.2017.11.17.11.16.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Nov 2017 11:16:26 -0800 (PST) From: Arvind Yadav To: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com, wens@csie.org, linux@roeck-us.net, wsa@the-dreams.de, daniel.thompson@linaro.org, mcuos.com@gmail.com Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/10] Input: sirfsoc-onkey: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 00:45:31 +0530 Message-Id: <1510946132-13554-10-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1510946132-13554-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/input/misc/sirfsoc-onkey.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c index 4fd038d..de04b48 100644 --- a/drivers/input/misc/sirfsoc-onkey.c +++ b/drivers/input/misc/sirfsoc-onkey.c @@ -149,6 +149,9 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev) sirfsoc_pwrc_toggle_interrupts(pwrcdrv, false); irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + error = devm_request_irq(&pdev->dev, irq, sirfsoc_pwrc_isr, 0, "sirfsoc_pwrc_int", pwrcdrv);