| Message ID | 20171118185011.4729-1-trond.myklebust@primarydata.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/18/2017 01:50 PM, Trond Myklebust wrote: > gcc 4.4.4 is too old to have full C11 anonymous union support, so > the current initialiser fails to compile. > > Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> (compile-)Tested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > --- > fs/nfs/nfs4state.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c > index 980462d577ca..231b5ea2464a 100644 > --- a/fs/nfs/nfs4state.c > +++ b/fs/nfs/nfs4state.c > @@ -71,8 +71,8 @@ const nfs4_stateid zero_stateid = { > }; > const nfs4_stateid invalid_stateid = { > { > - .seqid = cpu_to_be32(0xffffffffU), > - .other = { 0 }, > + /* Funky initialiser keeps older gcc versions happy */ > + .data = { 0xff, 0xff, 0xff, 0xff, 0 }, > }, > .type = NFS4_INVALID_STATEID_TYPE, > }; > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Nov 18, 2017 at 7:50 PM, Trond Myklebust <trond.myklebust@primarydata.com> wrote: > gcc 4.4.4 is too old to have full C11 anonymous union support, so > the current initialiser fails to compile. Thanks! Works fine with gcc-4.1.2, too. > Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 980462d577ca..231b5ea2464a 100644 --- a/fs/nfs/nfs4state.c +++ b/fs/nfs/nfs4state.c @@ -71,8 +71,8 @@ const nfs4_stateid zero_stateid = { }; const nfs4_stateid invalid_stateid = { { - .seqid = cpu_to_be32(0xffffffffU), - .other = { 0 }, + /* Funky initialiser keeps older gcc versions happy */ + .data = { 0xff, 0xff, 0xff, 0xff, 0 }, }, .type = NFS4_INVALID_STATEID_TYPE, };
gcc 4.4.4 is too old to have full C11 anonymous union support, so the current initialiser fails to compile. Reported-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> --- fs/nfs/nfs4state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)