| Message ID | 20171123020832.8165-9-mreitz@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, 11/23 03:08, Max Reitz wrote: > Signed-off-by: Max Reitz <mreitz@redhat.com> > --- > tests/qemu-iotests/103 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 > index ecbd8ebd71..d0cfab8844 100755 > --- a/tests/qemu-iotests/103 > +++ b/tests/qemu-iotests/103 > @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > _supported_fmt qcow2 > _supported_proto file nfs > _supported_os Linux > +# Internal snapshots are (currently) impossible with refcount_bits=1 > +_unsupported_imgopts 'refcount_bits=1[^0-9]' What is the "[^0-9]" part for? Fam
On 2017-11-30 04:18, Fam Zheng wrote: > On Thu, 11/23 03:08, Max Reitz wrote: >> Signed-off-by: Max Reitz <mreitz@redhat.com> >> --- >> tests/qemu-iotests/103 | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 >> index ecbd8ebd71..d0cfab8844 100755 >> --- a/tests/qemu-iotests/103 >> +++ b/tests/qemu-iotests/103 >> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >> _supported_fmt qcow2 >> _supported_proto file nfs >> _supported_os Linux >> +# Internal snapshots are (currently) impossible with refcount_bits=1 >> +_unsupported_imgopts 'refcount_bits=1[^0-9]' > > What is the "[^0-9]" part for? It's so you can specify refcount_bits=16, but not refcount_bits=1,compat=0.10 or just refcount_bits=1. Max
On 11/30/2017 08:23 AM, Max Reitz wrote: > On 2017-11-30 04:18, Fam Zheng wrote: >> On Thu, 11/23 03:08, Max Reitz wrote: >>> Signed-off-by: Max Reitz <mreitz@redhat.com> >>> --- >>> tests/qemu-iotests/103 | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 >>> index ecbd8ebd71..d0cfab8844 100755 >>> --- a/tests/qemu-iotests/103 >>> +++ b/tests/qemu-iotests/103 >>> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >>> _supported_fmt qcow2 >>> _supported_proto file nfs >>> _supported_os Linux >>> +# Internal snapshots are (currently) impossible with refcount_bits=1 >>> +_unsupported_imgopts 'refcount_bits=1[^0-9]' >> >> What is the "[^0-9]" part for? > > It's so you can specify refcount_bits=16, but not > refcount_bits=1,compat=0.10 or just refcount_bits=1. > > Max > Worth a comment? Reviewed-by: John Snow <jsnow@redhat.com>
On 2017-12-09 02:36, John Snow wrote: > > > On 11/30/2017 08:23 AM, Max Reitz wrote: >> On 2017-11-30 04:18, Fam Zheng wrote: >>> On Thu, 11/23 03:08, Max Reitz wrote: >>>> Signed-off-by: Max Reitz <mreitz@redhat.com> >>>> --- >>>> tests/qemu-iotests/103 | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 >>>> index ecbd8ebd71..d0cfab8844 100755 >>>> --- a/tests/qemu-iotests/103 >>>> +++ b/tests/qemu-iotests/103 >>>> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >>>> _supported_fmt qcow2 >>>> _supported_proto file nfs >>>> _supported_os Linux >>>> +# Internal snapshots are (currently) impossible with refcount_bits=1 >>>> +_unsupported_imgopts 'refcount_bits=1[^0-9]' >>> >>> What is the "[^0-9]" part for? >> >> It's so you can specify refcount_bits=16, but not >> refcount_bits=1,compat=0.10 or just refcount_bits=1. >> >> Max >> > > Worth a comment? There is a comment above it that says that refcount_bits=1 is the disallowed option. :-) I could add a "(refcount_bits=16 is OK, though)" if that would have been enough for you (or any proposal of yours). Max
On 12/11/2017 12:17 PM, Max Reitz wrote: > On 2017-12-09 02:36, John Snow wrote: >> >> >> On 11/30/2017 08:23 AM, Max Reitz wrote: >>> On 2017-11-30 04:18, Fam Zheng wrote: >>>> On Thu, 11/23 03:08, Max Reitz wrote: >>>>> Signed-off-by: Max Reitz <mreitz@redhat.com> >>>>> --- >>>>> tests/qemu-iotests/103 | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 >>>>> index ecbd8ebd71..d0cfab8844 100755 >>>>> --- a/tests/qemu-iotests/103 >>>>> +++ b/tests/qemu-iotests/103 >>>>> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 >>>>> _supported_fmt qcow2 >>>>> _supported_proto file nfs >>>>> _supported_os Linux >>>>> +# Internal snapshots are (currently) impossible with refcount_bits=1 >>>>> +_unsupported_imgopts 'refcount_bits=1[^0-9]' >>>> >>>> What is the "[^0-9]" part for? >>> >>> It's so you can specify refcount_bits=16, but not >>> refcount_bits=1,compat=0.10 or just refcount_bits=1. >>> >>> Max >>> >> >> Worth a comment? > > There is a comment above it that says that refcount_bits=1 is the > disallowed option. :-) > > I could add a "(refcount_bits=16 is OK, though)" if that would have been > enough for you (or any proposal of yours). > > Max > Not worth a re-spin. The double negative of "unsupported" and "not 0-9" takes a hot second to parse. Mentioning that you are looking to prohibit 1,[foo] specifically helps.
diff --git a/tests/qemu-iotests/103 b/tests/qemu-iotests/103 index ecbd8ebd71..d0cfab8844 100755 --- a/tests/qemu-iotests/103 +++ b/tests/qemu-iotests/103 @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 _supported_fmt qcow2 _supported_proto file nfs _supported_os Linux +# Internal snapshots are (currently) impossible with refcount_bits=1 +_unsupported_imgopts 'refcount_bits=1[^0-9]' IMG_SIZE=64K
Signed-off-by: Max Reitz <mreitz@redhat.com> --- tests/qemu-iotests/103 | 2 ++ 1 file changed, 2 insertions(+)