diff mbox

fix perl locale warnings in arch/arm/boot/

Message ID 20171127094620.GA18072@amd (mailing list archive)
State New, archived
Headers show

Commit Message

Pavel Machek Nov. 27, 2017, 9:46 a.m. UTC
Commit 429f7a062e3b5cf6fcf01eb00600cee5fe4d751f introduced perl into
arch/arm/boot/compressed/Makefile, which unfortunately leads to locale
warnings.

Fix it by setting default locale.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Comments

Pavel Machek Dec. 15, 2017, 8:16 p.m. UTC | #1
On Mon 2017-11-27 10:46:20, Pavel Machek wrote:
> 
> Commit 429f7a062e3b5cf6fcf01eb00600cee5fe4d751f introduced perl into
> arch/arm/boot/compressed/Makefile, which unfortunately leads to locale
> warnings.
> 
> Fix it by setting default locale.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

RMK apparently can't be bothered to fix the stuff he broke. Can
someone take the patch? Arm-soc? Linus? Andrew? 

Thanks,
								Pavel

> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index 45a6b9b..4656e98 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -118,7 +118,7 @@ asflags-y := -DZIMAGE
>  
>  # Supply kernel BSS size to the decompressor via a linker symbol.
>  KBSS_SZ = $(shell $(CROSS_COMPILE)nm $(obj)/../../../../vmlinux | \
> -		perl -e 'while (<>) { \
> +		LC_ALL=C perl -e 'while (<>) { \
>  			$$bss_start=hex($$1) if /^([[:xdigit:]]+) B __bss_start$$/; \
>  			$$bss_end=hex($$1) if /^([[:xdigit:]]+) B __bss_stop$$/; \
>  		}; printf "%d\n", $$bss_end - $$bss_start;')
> 
>
Masahiro Yamada Dec. 19, 2017, 8:24 a.m. UTC | #2
2017-12-16 5:16 GMT+09:00 Pavel Machek <pavel@ucw.cz>:
> On Mon 2017-11-27 10:46:20, Pavel Machek wrote:
>>
>> Commit 429f7a062e3b5cf6fcf01eb00600cee5fe4d751f introduced perl into
>> arch/arm/boot/compressed/Makefile, which unfortunately leads to locale
>> warnings.
>>
>> Fix it by setting default locale.
>>
>> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> RMK apparently can't be bothered to fix the stuff he broke. Can
> someone take the patch? Arm-soc? Linus? Andrew?
>
> Thanks,
>                                                                 Pavel

Russell does not directly pick up patches from ML.

If you want him to apply your patch,
you need to put it in his patch tracker.
(patches@arm.linux.org.uk)





>> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
>> index 45a6b9b..4656e98 100644
>> --- a/arch/arm/boot/compressed/Makefile
>> +++ b/arch/arm/boot/compressed/Makefile
>> @@ -118,7 +118,7 @@ asflags-y := -DZIMAGE
>>
>>  # Supply kernel BSS size to the decompressor via a linker symbol.
>>  KBSS_SZ = $(shell $(CROSS_COMPILE)nm $(obj)/../../../../vmlinux | \
>> -             perl -e 'while (<>) { \
>> +             LC_ALL=C perl -e 'while (<>) { \
>>                       $$bss_start=hex($$1) if /^([[:xdigit:]]+) B __bss_start$$/; \
>>                       $$bss_end=hex($$1) if /^([[:xdigit:]]+) B __bss_stop$$/; \
>>               }; printf "%d\n", $$bss_end - $$bss_start;')
>>
>>
>
>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
diff mbox

Patch

diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 45a6b9b..4656e98 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -118,7 +118,7 @@  asflags-y := -DZIMAGE
 
 # Supply kernel BSS size to the decompressor via a linker symbol.
 KBSS_SZ = $(shell $(CROSS_COMPILE)nm $(obj)/../../../../vmlinux | \
-		perl -e 'while (<>) { \
+		LC_ALL=C perl -e 'while (<>) { \
 			$$bss_start=hex($$1) if /^([[:xdigit:]]+) B __bss_start$$/; \
 			$$bss_end=hex($$1) if /^([[:xdigit:]]+) B __bss_stop$$/; \
 		}; printf "%d\n", $$bss_end - $$bss_start;')