iio: dummy_evgen: modify the return value check for irq_sim_init()
diff mbox

Message ID 20171127105449.27535-1-brgl@bgdev.pl
State New
Headers show

Commit Message

Bartosz Golaszewski Nov. 27, 2017, 10:54 a.m. UTC
As discussed with Marc Zyngier: irq_sim_init() and its devres variant
should return the base of the allocated interrupt range on success
rather than 0. This will be modified later - first, change the way
users handle the return value of these routines.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron Dec. 2, 2017, 11:43 a.m. UTC | #1
On Mon, 27 Nov 2017 11:54:49 +0100
Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> As discussed with Marc Zyngier: irq_sim_init() and its devres variant
> should return the base of the allocated interrupt range on success
> rather than 0. This will be modified later - first, change the way
> users handle the return value of these routines.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
I'm happy to take this but if it goes via my tree whilst the
other changes take a different path you are going to slow things
down considerably (a kernel cycle for this change to be in the
upstream of where the fix gets applied).  So I would bundle
it up in a single patch set with the more major changes.

If you still want me to take it let me know, but if it
might go via another route then

Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>

Thanks,

Jonathan
> ---
>  drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
> index fe8884543da0..efd0005f59b4 100644
> --- a/drivers/iio/dummy/iio_dummy_evgen.c
> +++ b/drivers/iio/dummy/iio_dummy_evgen.c
> @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
>  		return -ENOMEM;
>  
>  	ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
> -	if (ret) {
> +	if (ret < 0) {
>  		kfree(iio_evgen);
>  		return ret;
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Bartosz Golaszewski Dec. 2, 2017, 3:33 p.m. UTC | #2
2017-12-02 12:43 GMT+01:00 Jonathan Cameron <jic23@kernel.org>:
> On Mon, 27 Nov 2017 11:54:49 +0100
> Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
>> As discussed with Marc Zyngier: irq_sim_init() and its devres variant
>> should return the base of the allocated interrupt range on success
>> rather than 0. This will be modified later - first, change the way
>> users handle the return value of these routines.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> I'm happy to take this but if it goes via my tree whilst the
> other changes take a different path you are going to slow things
> down considerably (a kernel cycle for this change to be in the
> upstream of where the fix gets applied).  So I would bundle
> it up in a single patch set with the more major changes.
>
> If you still want me to take it let me know, but if it
> might go via another route then
>
> Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>
>
> Thanks,
>
> Jonathan
>> ---
>>  drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
>> index fe8884543da0..efd0005f59b4 100644
>> --- a/drivers/iio/dummy/iio_dummy_evgen.c
>> +++ b/drivers/iio/dummy/iio_dummy_evgen.c
>> @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
>>               return -ENOMEM;
>>
>>       ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
>> -     if (ret) {
>> +     if (ret < 0) {
>>               kfree(iio_evgen);
>>               return ret;
>>       }
>

There's no hurry with that, it doesn't cause any problems really and
the same change must be applied to gpio-mockup. I planned to actually
change the return value for 4.17 after all users are modified for
4.16.

How does it sound?

Thanks,
Bartosz
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron Dec. 10, 2017, 3:02 p.m. UTC | #3
On Sat, 2 Dec 2017 16:33:59 +0100
Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> 2017-12-02 12:43 GMT+01:00 Jonathan Cameron <jic23@kernel.org>:
> > On Mon, 27 Nov 2017 11:54:49 +0100
> > Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >  
> >> As discussed with Marc Zyngier: irq_sim_init() and its devres variant
> >> should return the base of the allocated interrupt range on success
> >> rather than 0. This will be modified later - first, change the way
> >> users handle the return value of these routines.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>  
> > I'm happy to take this but if it goes via my tree whilst the
> > other changes take a different path you are going to slow things
> > down considerably (a kernel cycle for this change to be in the
> > upstream of where the fix gets applied).  So I would bundle
> > it up in a single patch set with the more major changes.
> >
> > If you still want me to take it let me know, but if it
> > might go via another route then
> >
> > Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> >
> > Thanks,
> >
> > Jonathan  
> >> ---
> >>  drivers/iio/dummy/iio_dummy_evgen.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
> >> index fe8884543da0..efd0005f59b4 100644
> >> --- a/drivers/iio/dummy/iio_dummy_evgen.c
> >> +++ b/drivers/iio/dummy/iio_dummy_evgen.c
> >> @@ -56,7 +56,7 @@ static int iio_dummy_evgen_create(void)
> >>               return -ENOMEM;
> >>
> >>       ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
> >> -     if (ret) {
> >> +     if (ret < 0) {
> >>               kfree(iio_evgen);
> >>               return ret;
> >>       }  
> >  
> 
> There's no hurry with that, it doesn't cause any problems really and
> the same change must be applied to gpio-mockup. I planned to actually
> change the return value for 4.17 after all users are modified for
> 4.16.
> 
> How does it sound?
It's fine if slow.  Up to you though.

Anyhow, I've applied this to the togreg branch of iio.git and pushed out
as testing for the autobuilders to play with it.

Thanks,

Jonathan
> 
> Thanks,
> Bartosz

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/iio/dummy/iio_dummy_evgen.c b/drivers/iio/dummy/iio_dummy_evgen.c
index fe8884543da0..efd0005f59b4 100644
--- a/drivers/iio/dummy/iio_dummy_evgen.c
+++ b/drivers/iio/dummy/iio_dummy_evgen.c
@@ -56,7 +56,7 @@  static int iio_dummy_evgen_create(void)
 		return -ENOMEM;
 
 	ret = irq_sim_init(&iio_evgen->irq_sim, IIO_EVENTGEN_NO);
-	if (ret) {
+	if (ret < 0) {
 		kfree(iio_evgen);
 		return ret;
 	}