From patchwork Mon Nov 27 15:10:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10076997 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E869D6028E for ; Mon, 27 Nov 2017 15:13:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D97EA28F10 for ; Mon, 27 Nov 2017 15:13:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE2D028F16; Mon, 27 Nov 2017 15:13:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 5C5D228F17 for ; Mon, 27 Nov 2017 15:13:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 645E36E2E0; Mon, 27 Nov 2017 15:13:07 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40A866E299; Mon, 27 Nov 2017 15:13:05 +0000 (UTC) Received: from wuerfel.lan ([109.193.157.232]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0MNc8Q-1eDIPX3Wyg-007G88; Mon, 27 Nov 2017 16:12:54 +0100 From: Arnd Bergmann To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie Date: Mon, 27 Nov 2017 16:10:27 +0100 Message-Id: <20171127151239.1813673-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:0+ir7q/jfo3qaIfk6JvJKIPbEk3BlQZEdRjPMEBW9h08h+XJtyT pIdq3VojIzLuIOtZqOt0++GrUFHNfbgCHZd7/SMdfDKLY3bfekR5mLCA+ZIaVJdIwnj/iVG 0ejWkY50WnS7YLwPLe+QhitwTHp9wbCV8KnL3nUZeU9nnHSZ6xpiDh02wewSOidwYEuvkx1 7JkIR6hIk4p0MhdaQ9NMA== X-UI-Out-Filterresults: notjunk:1; V01:K0:th9wUq1swZA=:h+Jpsuvpngp7v2fUv1VbSb vjcz/nctKoMxk8a2dAJLdVKMxPo7MXa4umsnmG45t8N1DmtvFT79BVxz4ch5dzBrPaXlCSThy /pjHJ0XF+3q9ULrutlwgB0gqIvhR1AvZIV9+G8UUZC0Uo9JyurMttrqjSQWsVXCWDhkdjlVOY xMLD1l6r+HXGpA7wuy9Qft4xv6JFPF6z278kAImeTSNMpMqvFHtziPtRXaV3K+nTsuakqREpz Ayw1X9lx6kdrhK1IizdojlGaQDWdUFgq8qNbA5PeiBGiAl0VssxDBh22ouepjoEiIlruqi0KL rUNLQVoCxhQ4lIxUeFwF0ry15BBR8l8AZVov2/03cmJjPzblsR4+7IbZZ44+aNd8sXdfmGJDL tr2CjRQ7GAczRocv97YIJo1rkvlJ9qOjsbnYuyMiK0uXlAj5pnuV994MDdLuiOha/eaARNwRj KLotRzyrQBGWXYht6B040Lz6fsBHfg+qiFXiEysvxfr2EcZ7Fk/9FQks7/8AuWkgIgwuNXzNW uGeArAoMQE+iWqVgH/AKpOc1ngb+4112PCSa0RxQkp/bOEmKQbZchD6E3AjATWSH1esLGg90j 00XTWBoz/MspUrDUAU8IK0ubqAWoC+dqbC6d4qf8wntV5gnkStLdOwdCIvPzUUaGuH0PABUfE uiArcuJveIBsY/F3FIcAK+KgkAgNodSbXCHcMKcR2KHW/7PIfnp/IRrs68aIQi8SLH2KGwQaw c78kNbxth1VYe1EMkoRgYRWrjuQVrhfCLEa+HQ== Cc: Ander Conselvan de Oliveira , Arnd Bergmann , Daniel Vetter , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [Intel-gfx] [PATCH 1/2] drm/i915: fix intel_backlight_device_register declaration X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP The alternative intel_backlight_device_register() definition apparently never got used, but I have now run into a case of i915 being compiled without CONFIG_BACKLIGHT_CLASS_DEVICE, resulting in a number of identical warnings: drivers/gpu/drm/i915/intel_drv.h:1739:12: error: 'intel_backlight_device_register' defined but not used [-Werror=unused-function] This marks the function as 'inline', which was surely the original intention here. Fixes: 1ebaa0b9c2d4 ("drm/i915: Move backlight registration to connector registration") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/i915/intel_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 7bc60c848940..6c7f8bca574e 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1736,7 +1736,7 @@ extern struct drm_display_mode *intel_find_panel_downclock( int intel_backlight_device_register(struct intel_connector *connector); void intel_backlight_device_unregister(struct intel_connector *connector); #else /* CONFIG_BACKLIGHT_CLASS_DEVICE */ -static int intel_backlight_device_register(struct intel_connector *connector) +static inline int intel_backlight_device_register(struct intel_connector *connector) { return 0; }