From patchwork Wed Nov 29 03:08:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10081399 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA302602DC for ; Wed, 29 Nov 2017 03:08:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D938528558 for ; Wed, 29 Nov 2017 03:08:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC215286F7; Wed, 29 Nov 2017 03:08:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 498FE28558 for ; Wed, 29 Nov 2017 03:08:45 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id F02AB26788A; Wed, 29 Nov 2017 04:08:43 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id A6F50266B02; Wed, 29 Nov 2017 04:08:42 +0100 (CET) Received: from relmlie2.idc.renesas.com (relmlor3.renesas.com [210.160.252.173]) by alsa0.perex.cz (Postfix) with ESMTP id E91D7266B02 for ; Wed, 29 Nov 2017 04:08:39 +0100 (CET) Received: from unknown (HELO relmlir2.idc.renesas.com) ([10.200.68.152]) by relmlie2.idc.renesas.com with ESMTP; 29 Nov 2017 12:08:38 +0900 Received: from relmlii1.idc.renesas.com (relmlii1.idc.renesas.com [10.200.68.65]) by relmlir2.idc.renesas.com (Postfix) with ESMTP id 5AC1F727B5; Wed, 29 Nov 2017 12:08:38 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.44,470,1505746800"; d="scan'208";a="263609601" Received: from mail-sg2apc01lp0241.outbound.protection.outlook.com (HELO APC01-SG2-obe.outbound.protection.outlook.com) ([65.55.88.241]) by relmlii1.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 29 Nov 2017 12:08:37 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yu7QlPo1NmKAHqi2Z3/heut/ODhJ2xklsXcE77illXM=; b=DruOq8Nme94miFXnaljcsLRmZQTh71lI5dV1Zty3RBPjWr/oqjFmSQGXtkSZ1Lk4kxW1WOcZ9YLF2XwgYRmln74qjH79Hp2uMIP+BdLhACDaypB85SecRfTFX9xdDABJ+Ych1xZcmujzq127todrJZhI0b2vRjCrtn+amAly61E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.138) by KL1PR0601MB1879.apcprd06.prod.outlook.com (2603:1096:802:8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Wed, 29 Nov 2017 03:08:35 +0000 Message-ID: <87y3mprdre.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Wed, 29 Nov 2017 03:08:35 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: HK2PR02CA0193.apcprd02.prod.outlook.com (2603:1096:201:21::29) To KL1PR0601MB1879.apcprd06.prod.outlook.com (2603:1096:802:8::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f8548b83-8edf-479b-c794-08d536d67b6d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603263); SRVR:KL1PR0601MB1879; X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1879; 3:JQL39rWf2DtL73HdXjD6vyUYbxfj7bFh358G98/0d1I43xlgnNwnbrHlhbsuno5ZtoL88hvFZPsCdNb8XLlVJ8nM0CI5utnAQ0gLKuniMmxBsu2Fbrpx6CSzs45BfYpnKsyS+G61e7OfI9kJ1wFgyLMwpP45jyvU1LUjYhXBgE/whlBR9jiPOQIRNVOa6WYIue5JHLXqR5KWxx6dQGEn2si0mcYh73dYRgbZOuGzZeRw8C+6fJjuHZnQB2C/Bx5P; 25:/oITtm19hD3hm24T2he6WlV62nD61W1PUp9NfGnIYF12i2PpTpPhgPAh6IQnlEIV1ETN6RYB3FFsL+V/XITsP+pY3ZgT3/F8jVeUMaJFke6b5XahWr+xuI5YisdbHBPjlNv5tiVAc15mSKkvt1dkQS/4hHMSG33gVewYPCUUpfXx/XeF7gVnVldsrseh/i0mTO7M9B42CpDdj1NHxviUpDuF7nx4XN8L/B0ig5ccRgkuYAMs80lFLKAvFZ4X133wTIsC08ZUjR5iYi07XHnPwiO+JUgZ3TvbnGhXVO95i5zuqxVQQSdK3lwUxbwQ3ACwuj0IXm6rDP2P166XhTUsyA==; 31:9tf/bSt6VUlux7F2JO9osQ8Pp2UL6Lx4sHHGBqQhVN7W0UkarLZm13WYeRvMrqj74UX942ohTybwxx4vQQ/4PFH6bLKisHn2yQd6WqrWu9QwpXNK5ZiAnsqicn/iE8BOm9YMKz7gGPDDIi6lEc4H8nx0tlWIX/rk88AtEaSW3Y3LMhXE5XAB0Ok4uJRMLF1viEozYkKybCHoZuknkD9HPn7zvThnSMe4D7Gp1NqYL4M= X-MS-TrafficTypeDiagnostic: KL1PR0601MB1879: X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1879; 20:jYkqcpznGki3U2NWEo/xP6ilECGnvkPhDZkmiWQ6aXE58fNkVrNBl09sOvyNh3lnAv/SCKGjmrx5TKOjJbjRJmTwxbr6E+pugUlWEP+vhZtCNhrtbu7dBxxN+JQ4wpi84JZOMDVepdw40TktHkBr9ogiHksYRBWKq4LAwHk+HocGZaU/XFBT6JIuM6fMIjeAjqCcsP9zn6M0RHgCpiifaMNFl0IuKyCCDmXMjtQbnm8rEjCZbqgWB4dhSMFR1fvBDfVCBpz0PXRzus1Ot2WPJ4OOhq6eH1weRhXys3XC4NbwxR23FocCoE7pPH9Pnxegagbv6DOsGyJtocn14K8EiOi8a6HP4BTZyJQxcMJhFzZ434RY6IQaiMpV6UhH3g+9HFYlfQ5ictnFoeHN+/Hfhs48cYlGinmp15SmPqJYqieo259naclePpbCRApMPTrU0MJhrOd9WT8p6YPuRXgMKC/38SRN/kdVr3WvmVt/oP3vcK8xqJMiYQ8nRvjZ9U+/; 4:lKXbDb9Sz+bbsU7AwIFld3CvAiQusqHLFOIBdj2Ake/xS/24KlgLrBEhkRmAT5INWj/+A+eqMOZEo8KEdqFDr4vg4X+wAkOhMyIX2XeyuHvIDSNUG28NzMYXGbfIcFU0r4q9jQ9moPdYYnIAPS8dl2mxTp90HMv6K+XZkg6xwwBjgP3VbFh/4RCNmtfZyOnwm91UBzKGgYYvVfkHkbzv1inywLnfYKMwYShNSTxW6C3v0ttVqRJQEJQMVXeQOmARX9ZiI18hoWk4FpAWS74uQg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231022)(6055026)(6041248)(20161123558100)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(6072148)(201708071742011); SRVR:KL1PR0601MB1879; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:KL1PR0601MB1879; X-Forefront-PRVS: 05066DEDBB X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6009001)(366004)(39860400002)(376002)(346002)(199003)(189002)(47776003)(316002)(97736004)(81156014)(8676002)(58126008)(16586007)(81166006)(4326008)(68736007)(69596002)(8936002)(5660300001)(52116002)(25786009)(7696005)(66066001)(478600001)(106356001)(54906003)(305945005)(7736002)(53416004)(33646002)(3846002)(189998001)(23726003)(6116002)(86362001)(6486002)(2906002)(105586002)(50986999)(54356999)(53936002)(36756003)(6916009)(16526018)(83506002)(101416001)(50466002)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:KL1PR0601MB1879; H:morimoto-PC.renesas.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; KL1PR0601MB1879; 23:bEsVFa1YQBxWeG35uTBWRLFmkfU1Jh6RlnLz5Bw?= =?us-ascii?Q?+Philt0fav4CqhkqmoDJZArNoyl0DVRFqK16xctlgl4rItRyClIGQcuaoEnr?= =?us-ascii?Q?j6a1oiJ47ZgDpi86wQc8IU5ICtZLcC6fRRDThDkdrk1HEyc4VtSlMiuZZMPn?= =?us-ascii?Q?c2IYPNqxJrOK93ZILuIkgwiTns3A6UuwSmfnoUiN0Oh4q/3Y8AYRGLsTEz7v?= =?us-ascii?Q?puQpK1tfiEUXyOuCuB/9KnQexcP9XltvvxAqrpEWrkucbuR+kIiPWz8u2n37?= =?us-ascii?Q?hexU+OfPq6QllgDCKf4g5ozWGTt0++9GSRArtug8E/UL58H25TWl6Aalz+AR?= =?us-ascii?Q?8YgX9BzI6ElwDA7r0E/S5uJeXpYIBu5HWurgu56w9U0NUhCNg7hPrJ4swjVp?= =?us-ascii?Q?zAGJX+HVa67CIlW/sPDUrVofN5DfgJ/vfM+zPNbmKl5ISQH6dowsRAXP6+m4?= =?us-ascii?Q?danlLln32cQBJ5DETPsTdW0MJ+95iZ1/zFK2NTuzBMizuzGcQ7hVjNBdjCTn?= =?us-ascii?Q?imckA7XECx5zAmHi/jO5G3fxQJA4lZIYEICL/7KoGKXPV8UCx/3IzQewB0MG?= =?us-ascii?Q?B3IFnXhZrax634/URRXDuV8SjrqmzT7+rmhG1xDF+U8AyUhTozw2sZrBr/BM?= =?us-ascii?Q?ArabV3fIwSPwzwTpCTrr1SR+hSvLomhbTlqtB9xcDShlvCM2aHMvilgXedoR?= =?us-ascii?Q?96rryBshdmWA7brT3QWXgypAK73fvHUM3wc7NRRWV0JRqutv0xMT9yx+eiMZ?= =?us-ascii?Q?galSWCs7Dl5e58zjEQwqXzvxxafeezbBqPrHjMoWIuj7WTld6GSDIIx3P/x6?= =?us-ascii?Q?JjstdITkeNPFAqr/F4SmPPFUqND+RDI9MZaHBV6apYl+6clZSKtY0u0zupkv?= =?us-ascii?Q?zWQbgzJeR/islXm78l7VNEbBX1bpT4ugWYk51eUMxeYCNL9e52BCKYy5Ap8r?= =?us-ascii?Q?DQBaKDW/c11UkFtt4KOAq5onUNAMkW9k5lWW4vaO7hLhtl8bmZ7c+PRMU9oW?= =?us-ascii?Q?9ApTdMqvvCikiCoPPz1ETK+rHWHnMt4HYjiCnd8lcKTbCMnvgyy3kT3SnhNx?= =?us-ascii?Q?3vj9zz4FCfoMNg4++v8gpzJGuGjvWMwve1c6F5+x9KtVSq7Qgz29sXpP03fe?= =?us-ascii?Q?36RW/gkFg9oRJZf0msJDAMuAo8FJe39vp?= X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1879; 6:Pukz+/KFTiyqeFUpHLTwzJGtGYC8hMXuC1lqq20/nfgfcPeT3akKfY60YvLORgIrRqJ1lMjbfPnUGSJYKkM0gz2FEDqXUPJOpwW8BI0bOxkksyUVx7yBSgUVSpmR2YERkFgbMfUrvHepgmmlR4/pZY8e9H9+bQ4EcYB3obzuPK+MTYbrG1qtJCAHxlda8LwU7BP0uTO5Ejoo1Mu1FRjxHCAiz9GjRUB3tj54mbTHTzTxGqfFHrKE7YyXpH6DyubFvLBgzy/Jl4abkZGYlpyy4jGESG1pEqgIT1f5wq1SEnJ5LqOxif9HFDkQ97WIY/LYol0Du0dNvnkHGdaStiXkNozNNi8i0KLp8/SmYjDZ4bc=; 5:HNTFJH2gJiFuGTh5gQKhb9pM6/EA6QjablU7hvaE14Z0WVGpToRBCduNRctNVInimkaVFhz8+b6gKYGdL3IoIiNB/8eR0rDWHLBlPu5ASdYzlL5VciMxuvPERRebujX6/kk9jPbPK1nkVADa/Bnabfv2fu8/4dvN0GbOjaXb1YE=; 24:3GU7iRKNXRR9hYcuNEsL1iL/jv/dq//RkkDcD25QrsmRPMO+NbNosx6yjmNOcuT1bc0XbRuwFodd25CC2ZOar0RMdMlDMNJsidLJZUDg8Rs=; 7:7uui1WrK4iRo1z+vh6hUy4AssR6tYUy6YZUmiF8vBgMEMdWP2o3t6LxWbW1bDsKR8vFKjDJknwybnPCga0m07iwayWm7TlXAy0x1NuHui5f/yjMdV5LOec7tmtbk8FrwL8+s28H57T2d8e+OgZCSnVoS8spvsrNCgDTA+FwqWdF9+MtEXUHB4NQNrc/OAWw1+gYix+B0OC18n53RIy/H57mHBRXfjHipvs89UuwFNaitf+VoFXqPPUUnnjodzew2 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; KL1PR0601MB1879; 20:8S2xfmnFzNsptcY2/Mj+Ielt86pvuAcWTgXHdhqqRJILFLkwYoK8GSx68n2BvevlqjGEcXh3fhyW1+i0VEmm63gYl1Y8X/7FETpXKZKkqSk6Tx3LgbR+gyERAbaxQqVBFdfuhF73gjSiO8ViQDkPIkbjgVJQ/L6vK4lEa1xXzpw= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2017 03:08:35.9174 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8548b83-8edf-479b-c794-08d536d67b6d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1879 Cc: Linux-ALSA , Simon Subject: [alsa-devel] [PATCH] ASoC: rsnd: dma.c: spin lock is no longer needed in IRQ handler X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto DMA handler had needed to calculate pointer before, but it doesn't need now. Thus, we can remove unnecessary spin lock from DMAC handler. Signed-off-by: Kuninori Morimoto --- sound/soc/sh/rcar/dma.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c index 4d750bdf..41de234 100644 --- a/sound/soc/sh/rcar/dma.c +++ b/sound/soc/sh/rcar/dma.c @@ -71,25 +71,7 @@ struct rsnd_dma_ctrl { static void __rsnd_dmaen_complete(struct rsnd_mod *mod, struct rsnd_dai_stream *io) { - struct rsnd_priv *priv = rsnd_mod_to_priv(mod); - bool elapsed = false; - unsigned long flags; - - /* - * Renesas sound Gen1 needs 1 DMAC, - * Gen2 needs 2 DMAC. - * In Gen2 case, it are Audio-DMAC, and Audio-DMAC-peri-peri. - * But, Audio-DMAC-peri-peri doesn't have interrupt, - * and this driver is assuming that here. - */ - spin_lock_irqsave(&priv->lock, flags); - if (rsnd_io_is_working(io)) - elapsed = true; - - spin_unlock_irqrestore(&priv->lock, flags); - - if (elapsed) rsnd_dai_period_elapsed(io); }