[v2,5/8] ARM: dts: am335x-pepper: Fix the audio CODEC's reset pin
diff mbox

Message ID 20171129171359.29382-6-afd@ti.com
State New
Headers show

Commit Message

Andrew F. Davis Nov. 29, 2017, 5:13 p.m. UTC
The correct DT property for specifying a GPIO used for reset
is "reset-gpios", fix this here.

Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board")

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 arch/arm/boot/dts/am335x-pepper.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tony Lindgren Nov. 30, 2017, 4:18 p.m. UTC | #1
* Andrew F. Davis <afd@ti.com> [171129 17:16]:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.
> 
> Fixes: 4341881d0562 ("ARM: dts: Add devicetree for Gumstix Pepper board")

So it seems this and patch 8/8 are safe for me to pick separately?

Regards,

Tony

> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
>  arch/arm/boot/dts/am335x-pepper.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
> index 03c7d77023c6..9fb7426070ce 100644
> --- a/arch/arm/boot/dts/am335x-pepper.dts
> +++ b/arch/arm/boot/dts/am335x-pepper.dts
> @@ -139,7 +139,7 @@
>  &audio_codec {
>  	status = "okay";
>  
> -	gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>;
> +	reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>  	AVDD-supply = <&ldo3_reg>;
>  	IOVDD-supply = <&ldo3_reg>;
>  	DRVDD-supply = <&ldo3_reg>;
> -- 
> 2.15.0
>
Mark Brown Nov. 30, 2017, 4:33 p.m. UTC | #2
On Thu, Nov 30, 2017 at 08:18:26AM -0800, Tony Lindgren wrote:

> So it seems this and patch 8/8 are safe for me to pick separately?

It might make sense to pull in the relevant branches from ASoC first
however IIRC the reset GPIO code currently does nothing useful anyway so
it won't have any impact on bisection.  Andrew?
Andrew F. Davis Nov. 30, 2017, 4:37 p.m. UTC | #3
On 11/30/2017 10:33 AM, Mark Brown wrote:
> On Thu, Nov 30, 2017 at 08:18:26AM -0800, Tony Lindgren wrote:
> 
>> So it seems this and patch 8/8 are safe for me to pick separately?
> 
> It might make sense to pull in the relevant branches from ASoC first
> however IIRC the reset GPIO code currently does nothing useful anyway so
> it won't have any impact on bisection.  Andrew?
> 

Yeah, that's right, for safety it would be nice to take these after the
ASoC code, but it shouldn't matter in practice as the reset wasn't used
right anyway.
Mark Brown Nov. 30, 2017, 4:53 p.m. UTC | #4
On Thu, Nov 30, 2017 at 10:37:22AM -0600, Andrew F. Davis wrote:
> On 11/30/2017 10:33 AM, Mark Brown wrote:

> > It might make sense to pull in the relevant branches from ASoC first
> > however IIRC the reset GPIO code currently does nothing useful anyway so
> > it won't have any impact on bisection.  Andrew?

> Yeah, that's right, for safety it would be nice to take these after the
> ASoC code, but it shouldn't matter in practice as the reset wasn't used
> right anyway.

I'd just go for it.
Tony Lindgren Nov. 30, 2017, 5 p.m. UTC | #5
* Mark Brown <broonie@kernel.org> [171130 16:56]:
> On Thu, Nov 30, 2017 at 10:37:22AM -0600, Andrew F. Davis wrote:
> > On 11/30/2017 10:33 AM, Mark Brown wrote:
> 
> > > It might make sense to pull in the relevant branches from ASoC first
> > > however IIRC the reset GPIO code currently does nothing useful anyway so
> > > it won't have any impact on bisection.  Andrew?
> 
> > Yeah, that's right, for safety it would be nice to take these after the
> > ASoC code, but it shouldn't matter in practice as the reset wasn't used
> > right anyway.
> 
> I'd just go for it.

OK will apply the two omap dts changes for v4.16.

Thanks,

Tony

Patch
diff mbox

diff --git a/arch/arm/boot/dts/am335x-pepper.dts b/arch/arm/boot/dts/am335x-pepper.dts
index 03c7d77023c6..9fb7426070ce 100644
--- a/arch/arm/boot/dts/am335x-pepper.dts
+++ b/arch/arm/boot/dts/am335x-pepper.dts
@@ -139,7 +139,7 @@ 
 &audio_codec {
 	status = "okay";
 
-	gpio-reset = <&gpio1 16 GPIO_ACTIVE_LOW>;
+	reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
 	AVDD-supply = <&ldo3_reg>;
 	IOVDD-supply = <&ldo3_reg>;
 	DRVDD-supply = <&ldo3_reg>;