From patchwork Thu Nov 30 23:39:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sami Tolvanen X-Patchwork-Id: 10085783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 24FC5602BC for ; Thu, 30 Nov 2017 23:39:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16C202A2DC for ; Thu, 30 Nov 2017 23:39:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0AF8F2A41F; Thu, 30 Nov 2017 23:39:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88ED12A2DC for ; Thu, 30 Nov 2017 23:39:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751415AbdK3Xji (ORCPT ); Thu, 30 Nov 2017 18:39:38 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:37716 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbdK3XjV (ORCPT ); Thu, 30 Nov 2017 18:39:21 -0500 Received: by mail-it0-f67.google.com with SMTP id d137so514916itc.2 for ; Thu, 30 Nov 2017 15:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cPyF1NuGUdEEq7YJQmMnljaRXhdcsLAGvUiFeD7uOOU=; b=NU1YNPLO3Ki0XKKZW+nDUCj8o85zYR4zXBWd3AnoxSyo1LWY3l2Y/onXBEgKPrEpcx 9rmNkcSeTudUehZ/uxEM/IChD+NF+Qk+vlkAEREICKOMdWe58VT0hvChNjrknmhyvCSs Nq4BI77dK8nemHdKEjbqmL/naNEVLDkEsYRGOIajJH9CgtPLCpV9sg5wbfgPTQOY0PdJ 5vUHVjzR015f1SzikIU6Bsa+NKNoHIxtp6qh/LQUUlk51tP/fhDor19ujLeOIMVz9wJr AkHGjN/L4MrSNdG05r3u+TRpK7i8iroHtwqzf2RuGi4nzEfCVCIWGONmc6B2pU9zMXnc ZI3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cPyF1NuGUdEEq7YJQmMnljaRXhdcsLAGvUiFeD7uOOU=; b=lc1LwfYMsbBfpgNq8CyZUCRH3qBVg87m1lvW37rBg6UjK1HzHys6bNVqPiMEYhcVUU nhCfGk7ap2YVHgxH21TJJMv8cyUOFZi16OS5w71iCWFkavFm7T27TmUa56lld6QIxZ+r b8kSdufZK3Yr3QuTcbYMNpp1ZnYEMKtzCf12jmkON4fSh+Dmm3QPXN4kRqXRGgZ2p88v UC6KFz6L8JoBCwruQpxXdloENBMVV42gD/7Kgb2sbNQbRYfmuWwbxSi5uWH1wJ6edVXs TkCjCeg5cLpcNOKIKsBvbH5vKdeNTV+tuZAHgfi3af1cti3zc9jV1BluzrL5Ngjh+kXg Y16Q== X-Gm-Message-State: AJaThX64QS0QC+d4hUE67N9scydYythJF0L0muyp1oFUNYoGp1BzBR3Q AX5Mchk4NKkH/OZ6bRyF+clwXA== X-Google-Smtp-Source: AGs4zMY3ssS3mjK3kWSnR6pn9nVHhMMJ689XHQD4BzCdEt3EFNUzhkzbOFYdc/4Ab3qhRLwbs7OXmw== X-Received: by 10.36.44.197 with SMTP id i188mr5656950iti.40.1512085160644; Thu, 30 Nov 2017 15:39:20 -0800 (PST) Received: from samitolvanen.mtv.corp.google.com ([100.98.112.14]) by smtp.gmail.com with ESMTPSA id h73sm2896676itb.21.2017.11.30.15.39.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Nov 2017 15:39:19 -0800 (PST) From: Sami Tolvanen To: Alex Matveev , Andi Kleen , Ard Biesheuvel , Greg Hackmann , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , Masahiro Yamada , Maxim Kuvyrkov , Michal Marek , Nick Desaulniers , Yury Norov , Matthias Kaehlcke , Nicholas Piggin Cc: Sami Tolvanen Subject: [PATCH v2 7/7] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Date: Thu, 30 Nov 2017 15:39:05 -0800 Message-Id: <20171130233905.130602-8-samitolvanen@google.com> X-Mailer: git-send-email 2.15.0.531.g2ccb3012c9-goog In-Reply-To: <20171130233905.130602-1-samitolvanen@google.com> References: <20171129234442.655-1-samitolvanen@google.com> <20171130233905.130602-1-samitolvanen@google.com> Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP All current versions of GNU gold crash when linking kernel modules with ARM64_MODULE_PLTS due to a known bug: https://sourceware.org/bugzilla/show_bug.cgi?id=14592 To work around the problem, this change removes NOLOAD from .plt and .init.plt. Signed-off-by: Sami Tolvanen Acked-by: Ard Biesheuvel --- arch/arm64/kernel/module.lds | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/module.lds b/arch/arm64/kernel/module.lds index f7c9781a9d48..eacb5c67f61e 100644 --- a/arch/arm64/kernel/module.lds +++ b/arch/arm64/kernel/module.lds @@ -1,4 +1,4 @@ SECTIONS { - .plt (NOLOAD) : { BYTE(0) } - .init.plt (NOLOAD) : { BYTE(0) } + .plt : { BYTE(0) } + .init.plt : { BYTE(0) } }