Patchwork [2/2] dm-flakey: Check for null arg_name

login
register
mail settings
Submitter Goldwyn Rodrigues
Date Dec. 4, 2017, 3:14 a.m.
Message ID <20171204031412.2435-2-rgoldwyn@suse.de>
Download mbox | patch
Permalink /patch/10089579/
State Accepted, archived
Delegated to: Mike Snitzer
Headers show

Comments

Goldwyn Rodrigues - Dec. 4, 2017, 3:14 a.m.
From: Goldwyn Rodrigues <rgoldwyn@suse.com>

One can crash dm-flakey by specifying more number of feature arguments
than the number of features supplied. Checking for null in arg_name
avoids this.

dmsetup create flakey-test --table "0 66076080 flakey /dev/sdb9 0 0 180 2 \
drop_writes"

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
---
 drivers/md/dm-flakey.c | 5 +++++
 1 file changed, 5 insertions(+)

Patch

diff --git a/drivers/md/dm-flakey.c b/drivers/md/dm-flakey.c
index e18c29672a88..995b69e98f9f 100644
--- a/drivers/md/dm-flakey.c
+++ b/drivers/md/dm-flakey.c
@@ -70,6 +70,11 @@  static int parse_features(struct dm_arg_set *as, struct flakey_c *fc,
 		arg_name = dm_shift_arg(as);
 		argc--;
 
+		if (!arg_name) {
+			ti->error = "Insufficient feature arguments";
+			return -EINVAL;
+		}
+
 		/*
 		 * drop_writes
 		 */