[next] iio: light: make a couple of config structures static
diff mbox

Message ID 20171204120406.4364-1-colin.king@canonical.com
State New
Headers show

Commit Message

Colin King Dec. 4, 2017, 12:04 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Structures st_uvis25_i2c_regmap_config and st_uvis25_spi_regmap_config are
local to the source and do not need to be in global scope, so make them
both static.

Cleans up sparse warnings:
warning: symbol 'st_uvis25_i2c_regmap_config' was not declared. Should
it be static?
warning: symbol 'st_uvis25_spi_regmap_config' was not declared. Should
it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iio/light/st_uvis25_i2c.c | 2 +-
 drivers/iio/light/st_uvis25_spi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron Dec. 10, 2017, 4:23 p.m. UTC | #1
On Mon,  4 Dec 2017 12:04:06 +0000
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Structures st_uvis25_i2c_regmap_config and st_uvis25_spi_regmap_config are
> local to the source and do not need to be in global scope, so make them
> both static.
> 
> Cleans up sparse warnings:
> warning: symbol 'st_uvis25_i2c_regmap_config' was not declared. Should
> it be static?
> warning: symbol 'st_uvis25_spi_regmap_config' was not declared. Should
> it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks Colin,

Not sure why I missed these when running build tests and they got past
0-day.  Ah well..  Applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to play with them.

Thanks,

Jonathan

> ---
>  drivers/iio/light/st_uvis25_i2c.c | 2 +-
>  drivers/iio/light/st_uvis25_spi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/st_uvis25_i2c.c b/drivers/iio/light/st_uvis25_i2c.c
> index c939c0b0ff10..afd6eb01a202 100644
> --- a/drivers/iio/light/st_uvis25_i2c.c
> +++ b/drivers/iio/light/st_uvis25_i2c.c
> @@ -19,7 +19,7 @@
>  
>  #define UVIS25_I2C_AUTO_INCREMENT	BIT(7)
>  
> -const struct regmap_config st_uvis25_i2c_regmap_config = {
> +static const struct regmap_config st_uvis25_i2c_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.write_flag_mask = UVIS25_I2C_AUTO_INCREMENT,
> diff --git a/drivers/iio/light/st_uvis25_spi.c b/drivers/iio/light/st_uvis25_spi.c
> index e697e14e7952..cdfee5e84d5e 100644
> --- a/drivers/iio/light/st_uvis25_spi.c
> +++ b/drivers/iio/light/st_uvis25_spi.c
> @@ -19,7 +19,7 @@
>  #define UVIS25_SENSORS_SPI_READ		BIT(7)
>  #define UVIS25_SPI_AUTO_INCREMENT	BIT(6)
>  
> -const struct regmap_config st_uvis25_spi_regmap_config = {
> +static const struct regmap_config st_uvis25_spi_regmap_config = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
>  	.read_flag_mask = UVIS25_SENSORS_SPI_READ | UVIS25_SPI_AUTO_INCREMENT,

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/drivers/iio/light/st_uvis25_i2c.c b/drivers/iio/light/st_uvis25_i2c.c
index c939c0b0ff10..afd6eb01a202 100644
--- a/drivers/iio/light/st_uvis25_i2c.c
+++ b/drivers/iio/light/st_uvis25_i2c.c
@@ -19,7 +19,7 @@ 
 
 #define UVIS25_I2C_AUTO_INCREMENT	BIT(7)
 
-const struct regmap_config st_uvis25_i2c_regmap_config = {
+static const struct regmap_config st_uvis25_i2c_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
 	.write_flag_mask = UVIS25_I2C_AUTO_INCREMENT,
diff --git a/drivers/iio/light/st_uvis25_spi.c b/drivers/iio/light/st_uvis25_spi.c
index e697e14e7952..cdfee5e84d5e 100644
--- a/drivers/iio/light/st_uvis25_spi.c
+++ b/drivers/iio/light/st_uvis25_spi.c
@@ -19,7 +19,7 @@ 
 #define UVIS25_SENSORS_SPI_READ		BIT(7)
 #define UVIS25_SPI_AUTO_INCREMENT	BIT(6)
 
-const struct regmap_config st_uvis25_spi_regmap_config = {
+static const struct regmap_config st_uvis25_spi_regmap_config = {
 	.reg_bits = 8,
 	.val_bits = 8,
 	.read_flag_mask = UVIS25_SENSORS_SPI_READ | UVIS25_SPI_AUTO_INCREMENT,