Patchwork [2/2] video: ARM CLCD: Improve a size determination in clcdfb_probe()

login
register
mail settings
Submitter SF Markus Elfring
Date Dec. 5, 2017, 5:13 p.m.
Message ID <3656de6d-53cc-f6a4-1950-71fc989c79a4@users.sourceforge.net>
Download mbox | patch
Permalink /patch/10093479/
State New
Headers show

Comments

SF Markus Elfring - Dec. 5, 2017, 5:13 p.m.
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 5 Dec 2017 17:53:19 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/video/fbdev/amba-clcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 79f5ebf23fcd..38c1f324ce15 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -967,7 +967,7 @@  static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id)
 		goto out;
 	}
 
-	fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL);
+	fb = kzalloc(sizeof(*fb), GFP_KERNEL);
 	if (!fb) {
 		ret = -ENOMEM;
 		goto free_region;