drm/sun4i: Fix uninitialized variables in vi layer
diff mbox

Message ID 20171206152603.25937-1-jernej.skrabec@siol.net
State New
Headers show

Commit Message

Jernej Skrabec Dec. 6, 2017, 3:26 p.m. UTC
min_scale and max_scale in sun8i_vi_layer_atomic_check() can be used
without initialization.

Fix that.

Fixes: 	b862a648de3b (drm/sun4i: Add support for HW scaling to DE2)

Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
 drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Maxime Ripard Dec. 7, 2017, 8:51 a.m. UTC | #1
Hi,

On Wed, Dec 06, 2017 at 04:26:03PM +0100, Jernej Skrabec wrote:
> min_scale and max_scale in sun8i_vi_layer_atomic_check() can be used
> without initialization.
> 
> Fix that.
> 
> Fixes: 	b862a648de3b (drm/sun4i: Add support for HW scaling to DE2)
> 
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

I've applied this, but your fixes tag was at the wrong format. You
should use the one documented here:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

or you can even use the git option to generate it directly.

Maxime

Patch
diff mbox

diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
index e39af8d377d0..40c3b303068a 100644
--- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c
@@ -253,6 +253,9 @@  static int sun8i_vi_layer_atomic_check(struct drm_plane *plane,
 	clip.x2 = crtc_state->adjusted_mode.hdisplay;
 	clip.y2 = crtc_state->adjusted_mode.vdisplay;
 
+	min_scale = DRM_PLANE_HELPER_NO_SCALING;
+	max_scale = DRM_PLANE_HELPER_NO_SCALING;
+
 	if (layer->mixer->cfg->scaler_mask & BIT(layer->channel)) {
 		min_scale = SUN8I_VI_SCALER_SCALE_MIN;
 		max_scale = SUN8I_VI_SCALER_SCALE_MAX;