From patchwork Thu Dec 7 14:49:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 10099351 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD0CA60360 for ; Thu, 7 Dec 2017 14:49:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEFA329F6A for ; Thu, 7 Dec 2017 14:49:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B37A12A472; Thu, 7 Dec 2017 14:49:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BBD312A1B2 for ; Thu, 7 Dec 2017 14:49:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE95B6E21D; Thu, 7 Dec 2017 14:49:35 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 335116E21A for ; Thu, 7 Dec 2017 14:49:33 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id b76so13439895wmg.1 for ; Thu, 07 Dec 2017 06:49:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=VtwAuFferfdEJKyx5bPon43qvH24NQVxEAlmN1wnX9Q=; b=cpr1QCrNcdtQx9ChojoRde7f+s3BHlPMLyVYtEO5EwynNhBxlYXBc14Em9fEzj8b4C y+Flq5ytbpoCZWqU4PHXaQRqhajtUfsDyWeU4BoY0Tf19qyeg2AZRM2E1OOLITTChfRw 8nOMwNm3VMGsCIIcf9xUDjZu7jw61JwXNqgp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=VtwAuFferfdEJKyx5bPon43qvH24NQVxEAlmN1wnX9Q=; b=BO67j/st+izMNi2X8gHi6g8OjRRgbbiMUUqKnG8Yp7rFlDHTip18ntM1t8bX8RK6ct MjVJoyB4G3nykcPPa255KFPa/HNtHUn3VTuwDSYwoQD3eS1l0TzEAOQNRMKxHDYDyQPK /VlwSdTutn5ZyPTF7rfAmP+LReiqq+JDOyFFSFu1NTIfU+XK7C6mdmTpUBgbXHWN97Ht 7GjsYnWWCoIrYoiZWfGlUi2Lby3mykH3TXIv7c1wmg8S20nr8gL/jDtcDeCCB/jEJx+i zJfRWJ/yTsPFzGzjlwia1sDUUGPug3Nq+6+3Ee8a5m52rCmaGmyGfzjjyQFglv29plnM KVMA== X-Gm-Message-State: AJaThX4M9nO0N5s8Ke87JNHTA2NlT3dSDcI7H5sUYH4H3bLeq9+Dozib YGwAJXtap+NfLrHUzAo9PVnecKRn X-Google-Smtp-Source: AGs4zMYmJjgv5o3dU0KIR8NS/p16odFM3A/rECG3PcxKGvA+NFHdfnC/FIU1Er4z+FVc7KpHd9ik3w== X-Received: by 10.80.181.83 with SMTP id z19mr46129592edd.48.1512658172393; Thu, 07 Dec 2017 06:49:32 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:5635:0:39d2:f87e:2033:9f6]) by smtp.gmail.com with ESMTPSA id m48sm2379362edd.7.2017.12.07.06.49.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Dec 2017 06:49:31 -0800 (PST) From: Daniel Vetter To: Intel Graphics Development Date: Thu, 7 Dec 2017 15:49:25 +0100 Message-Id: <20171207144925.14191-1-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.15.0 Cc: Daniel Vetter , DRI Development , Daniel Vetter Subject: [Intel-gfx] [PATCH] drm: More debug info for fb leaks in mode_config_cleanup X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP We're spotting this very rarely in CI, but have no idea. Let's add more debug info about what's going on here. References: https://bugs.freedesktop.org/show_bug.cgi?id=102707 Signed-off-by: Daniel Vetter Acked-by: Noralf Trønnes --- drivers/gpu/drm/drm_mode_config.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c index cc78b3d9e5e4..6ffe952142e6 100644 --- a/drivers/gpu/drm/drm_mode_config.c +++ b/drivers/gpu/drm/drm_mode_config.c @@ -469,6 +469,9 @@ void drm_mode_config_cleanup(struct drm_device *dev) */ WARN_ON(!list_empty(&dev->mode_config.fb_list)); list_for_each_entry_safe(fb, fbt, &dev->mode_config.fb_list, head) { + struct drm_printer p = drm_debug_printer("[leaked fb]"); + drm_printf(&p, "framebuffer[%u]:\n", fb->base.id); + drm_framebuffer_print_info(&p, 1, fb); drm_framebuffer_free(&fb->base.refcount); }