Patchwork crypto: api - Unexport crypto_larval_lookup()

login
register
mail settings
Submitter Eric Biggers
Date Dec. 7, 2017, 6:55 p.m.
Message ID <20171207185559.17087-1-ebiggers3@gmail.com>
Download mbox | patch
Permalink /patch/10100871/
State Accepted
Delegated to: Herbert Xu
Headers show

Comments

Eric Biggers - Dec. 7, 2017, 6:55 p.m.
From: Eric Biggers <ebiggers@google.com>

crypto_larval_lookup() is not used outside of crypto/api.c, so unexport
it and mark it 'static'.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/api.c      | 4 ++--
 crypto/internal.h | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)
Herbert Xu - Dec. 22, 2017, 8:42 a.m.
Eric Biggers <ebiggers3@gmail.com> wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> crypto_larval_lookup() is not used outside of crypto/api.c, so unexport
> it and mark it 'static'.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Patch applied.  Thanks.

Patch

diff --git a/crypto/api.c b/crypto/api.c
index 2a2479d168aa..6da802d7be67 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -205,7 +205,8 @@  struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask)
 }
 EXPORT_SYMBOL_GPL(crypto_alg_lookup);
 
-struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
+static struct crypto_alg *crypto_larval_lookup(const char *name, u32 type,
+					       u32 mask)
 {
 	struct crypto_alg *alg;
 
@@ -231,7 +232,6 @@  struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask)
 
 	return crypto_larval_add(name, type, mask);
 }
-EXPORT_SYMBOL_GPL(crypto_larval_lookup);
 
 int crypto_probing_notify(unsigned long val, void *v)
 {
diff --git a/crypto/internal.h b/crypto/internal.h
index f07320423191..ae65e5fcaa59 100644
--- a/crypto/internal.h
+++ b/crypto/internal.h
@@ -78,7 +78,6 @@  int crypto_init_compress_ops(struct crypto_tfm *tfm);
 
 struct crypto_larval *crypto_larval_alloc(const char *name, u32 type, u32 mask);
 void crypto_larval_kill(struct crypto_alg *alg);
-struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask);
 void crypto_alg_tested(const char *name, int err);
 
 void crypto_remove_spawns(struct crypto_alg *alg, struct list_head *list,