Patchwork [4/9] pci: remove unneeded kallsyms include

login
register
mail settings
Submitter Sergey Senozhatsky
Date Dec. 8, 2017, 2:56 a.m.
Message ID <20171208025616.16267-5-sergey.senozhatsky@gmail.com>
Download mbox | patch
Permalink /patch/10101515/
State New
Headers show

Comments

Sergey Senozhatsky - Dec. 8, 2017, 2:56 a.m.
The file was converted from print_fn_descriptor_symbol()
to %pF some time ago (c9bbb4abb658da "PCI: use %pF instead
of print_fn_descriptor_symbol() in quirks.c"). kallsyms does
not seem to be needed anymore.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/quirks.c | 1 -
 1 file changed, 1 deletion(-)
Bjorn Helgaas - Dec. 8, 2017, 5:53 p.m.
On Fri, Dec 08, 2017 at 11:56:11AM +0900, Sergey Senozhatsky wrote:
> The file was converted from print_fn_descriptor_symbol()
> to %pF some time ago (c9bbb4abb658da "PCI: use %pF instead
> of print_fn_descriptor_symbol() in quirks.c"). kallsyms does
> not seem to be needed anymore.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>

Applied to pci/misc for v4.16, thanks for cleaning this up!

I *assume* there's no ordering dependency like the one you mentioned
for sched/printk.  If there is, let me know, and I'll move this to
for-linus to get it in v4.15.

> ---
>  drivers/pci/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index 10684b17d0bd..fd49b976973f 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -19,7 +19,6 @@
>  #include <linux/init.h>
>  #include <linux/delay.h>
>  #include <linux/acpi.h>
> -#include <linux/kallsyms.h>
>  #include <linux/dmi.h>
>  #include <linux/pci-aspm.h>
>  #include <linux/ioport.h>
> -- 
> 2.15.1
>
Sergey Senozhatsky - Dec. 8, 2017, 11:55 p.m.
On (12/08/17 11:53), Bjorn Helgaas wrote:
> On Fri, Dec 08, 2017 at 11:56:11AM +0900, Sergey Senozhatsky wrote:
> > The file was converted from print_fn_descriptor_symbol()
> > to %pF some time ago (c9bbb4abb658da "PCI: use %pF instead
> > of print_fn_descriptor_symbol() in quirks.c"). kallsyms does
> > not seem to be needed anymore.
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> 
> Applied to pci/misc for v4.16, thanks for cleaning this up!

thanks!

> I *assume* there's no ordering dependency like the one you mentioned
> for sched/printk.

no dependency. you are right.

	-ss

Patch

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 10684b17d0bd..fd49b976973f 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -19,7 +19,6 @@ 
 #include <linux/init.h>
 #include <linux/delay.h>
 #include <linux/acpi.h>
-#include <linux/kallsyms.h>
 #include <linux/dmi.h>
 #include <linux/pci-aspm.h>
 #include <linux/ioport.h>