Patchwork [5/9] pnp: remove unneeded kallsyms include

login
register
mail settings
Submitter Sergey Senozhatsky
Date Dec. 8, 2017, 2:56 a.m.
Message ID <20171208025616.16267-6-sergey.senozhatsky@gmail.com>
Download mbox | patch
Permalink /patch/10101547/
State New
Headers show

Comments

Sergey Senozhatsky - Dec. 8, 2017, 2:56 a.m.
The file was converted from print_fn_descriptor_symbol()
to %pF some time ago (2e532d68a2b3e2aa {pci,pnp} quirks.c:
don't use deprecated print_fn_descriptor_symbol()). kallsyms
does not seem to be needed anymore.

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pnp/quirks.c | 1 -
 1 file changed, 1 deletion(-)
Rafael J. Wysocki - Dec. 8, 2017, 2:02 p.m.
On Fri, Dec 8, 2017 at 3:56 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@gmail.com> wrote:
> The file was converted from print_fn_descriptor_symbol()
> to %pF some time ago (2e532d68a2b3e2aa {pci,pnp} quirks.c:
> don't use deprecated print_fn_descriptor_symbol()). kallsyms
> does not seem to be needed anymore.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pnp/quirks.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> index f054cdddfef8..803666ae3635 100644
> --- a/drivers/pnp/quirks.c
> +++ b/drivers/pnp/quirks.c
> @@ -21,7 +21,6 @@
>  #include <linux/slab.h>
>  #include <linux/pnp.h>
>  #include <linux/io.h>
> -#include <linux/kallsyms.h>
>  #include "base.h"
>
>  static void quirk_awe32_add_ports(struct pnp_dev *dev,
> --

Do you want me to apply this or do you want to route it differently?
Sergey Senozhatsky - Dec. 8, 2017, 2:49 p.m.
On (12/08/17 15:02), Rafael J. Wysocki wrote:
> On Fri, Dec 8, 2017 at 3:56 AM, Sergey Senozhatsky
> <sergey.senozhatsky.work@gmail.com> wrote:
> > The file was converted from print_fn_descriptor_symbol()
> > to %pF some time ago (2e532d68a2b3e2aa {pci,pnp} quirks.c:
> > don't use deprecated print_fn_descriptor_symbol()). kallsyms
> > does not seem to be needed anymore.
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > ---
> >  drivers/pnp/quirks.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> > index f054cdddfef8..803666ae3635 100644
> > --- a/drivers/pnp/quirks.c
> > +++ b/drivers/pnp/quirks.c
> > @@ -21,7 +21,6 @@
> >  #include <linux/slab.h>
> >  #include <linux/pnp.h>
> >  #include <linux/io.h>
> > -#include <linux/kallsyms.h>
> >  #include "base.h"
> >
> >  static void quirk_awe32_add_ports(struct pnp_dev *dev,
> > --
> 
> Do you want me to apply this or do you want to route it differently?

please pick it up.

	-ss
Rafael Wysocki - Dec. 17, 2017, 6:04 p.m.
On Friday, December 8, 2017 3:49:09 PM CET Sergey Senozhatsky wrote:
> On (12/08/17 15:02), Rafael J. Wysocki wrote:
> > On Fri, Dec 8, 2017 at 3:56 AM, Sergey Senozhatsky
> > <sergey.senozhatsky.work@gmail.com> wrote:
> > > The file was converted from print_fn_descriptor_symbol()
> > > to %pF some time ago (2e532d68a2b3e2aa {pci,pnp} quirks.c:
> > > don't use deprecated print_fn_descriptor_symbol()). kallsyms
> > > does not seem to be needed anymore.
> > >
> > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > ---
> > >  drivers/pnp/quirks.c | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> > > index f054cdddfef8..803666ae3635 100644
> > > --- a/drivers/pnp/quirks.c
> > > +++ b/drivers/pnp/quirks.c
> > > @@ -21,7 +21,6 @@
> > >  #include <linux/slab.h>
> > >  #include <linux/pnp.h>
> > >  #include <linux/io.h>
> > > -#include <linux/kallsyms.h>
> > >  #include "base.h"
> > >
> > >  static void quirk_awe32_add_ports(struct pnp_dev *dev,
> > > --
> > 
> > Do you want me to apply this or do you want to route it differently?
> 
> please pick it up.

Applied, thanks!

Patch

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index f054cdddfef8..803666ae3635 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -21,7 +21,6 @@ 
 #include <linux/slab.h>
 #include <linux/pnp.h>
 #include <linux/io.h>
-#include <linux/kallsyms.h>
 #include "base.h"
 
 static void quirk_awe32_add_ports(struct pnp_dev *dev,