| Message ID | 20171210220213.19290-1-nerijus@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On 10-12-17 23:02, Nerijus Baliunas wrote: > Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net> Looks good to me: Acked-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 266535c2a72f..414293e8c448 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = { > .properties = digma_citi_e200_props, > }; > > +static const struct property_entry onda_obook_20_plus_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct silead_ts_dmi_data onda_obook_20_plus_data = { > + .acpi_name = "MSSL1680:00", > + .properties = onda_obook_20_plus_props, > +}; > + > static const struct dmi_system_id silead_ts_dmi_table[] = { > { > /* CUBE iwork8 Air */ > @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > }, > }, > + { > + /* Onda oBook 20 Plus */ > + .driver_data = (void *)&onda_obook_20_plus_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"), > + }, > + }, > { }, > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks!
> + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"),
Firmware for this is available here:
https://github.com/onitake/gsl-firmware/blob/master/firmware/linux/silead/gsl3676-onda-obook-20-plus.fw
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 11 Dec 2017 19:25:40 +0100 Gregor Riepl <onitake@gmail.com> wrote: > > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"), > > Firmware for this is available here: > https://github.com/onitake/gsl-firmware/blob/master/firmware/linux/silead/gsl3676-onda-obook-20-plus.fw BTW, what could be done with these firmware files? Is it possible to include them in linux-firmware? Regards, Nerijus -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Dec 11, 2017 at 12:02 AM, Nerijus Baliunas <nerijus@users.sourceforge.net> wrote: > Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net> Applied to my review and testing queue with massaged title and written commit message, thanks. Please, don't forget to do it yourself next time, otherwise it will slow review and promoting. > --- > drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c > index 266535c2a72f..414293e8c448 100644 > --- a/drivers/platform/x86/silead_dmi.c > +++ b/drivers/platform/x86/silead_dmi.c > @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = { > .properties = digma_citi_e200_props, > }; > > +static const struct property_entry onda_obook_20_plus_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), > + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct silead_ts_dmi_data onda_obook_20_plus_data = { > + .acpi_name = "MSSL1680:00", > + .properties = onda_obook_20_plus_props, > +}; > + > static const struct dmi_system_id silead_ts_dmi_table[] = { > { > /* CUBE iwork8 Air */ > @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { > DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), > }, > }, > + { > + /* Onda oBook 20 Plus */ > + .driver_data = (void *)&onda_obook_20_plus_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"), > + }, > + }, > { }, > }; > > -- > 2.14.3 >
diff --git a/drivers/platform/x86/silead_dmi.c b/drivers/platform/x86/silead_dmi.c index 266535c2a72f..414293e8c448 100644 --- a/drivers/platform/x86/silead_dmi.c +++ b/drivers/platform/x86/silead_dmi.c @@ -171,6 +171,23 @@ static const struct silead_ts_dmi_data digma_citi_e200_data = { .properties = digma_citi_e200_props, }; +static const struct property_entry onda_obook_20_plus_props[] = { + PROPERTY_ENTRY_U32("touchscreen-size-x", 1728), + PROPERTY_ENTRY_U32("touchscreen-size-y", 1148), + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), + PROPERTY_ENTRY_STRING("firmware-name", "gsl3676-onda-obook-20-plus.fw"), + PROPERTY_ENTRY_U32("silead,max-fingers", 10), + PROPERTY_ENTRY_BOOL("silead,home-button"), + { } +}; + +static const struct silead_ts_dmi_data onda_obook_20_plus_data = { + .acpi_name = "MSSL1680:00", + .properties = onda_obook_20_plus_props, +}; + static const struct dmi_system_id silead_ts_dmi_table[] = { { /* CUBE iwork8 Air */ @@ -271,6 +288,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = { DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"), }, }, + { + /* Onda oBook 20 Plus */ + .driver_data = (void *)&onda_obook_20_plus_data, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"), + DMI_MATCH(DMI_PRODUCT_NAME, "OBOOK 20 PLUS"), + }, + }, { }, };
Signed-off-by: Nerijus Baliūnas <nerijus@users.sourceforge.net> --- drivers/platform/x86/silead_dmi.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+)