[v4,3/3] dt-bindings: iio: temperature: add MLX90632 device bindings
diff mbox

Message ID 20171211092002.8687-1-cmo@melexis.com
State New
Headers show

Commit Message

Crt Mori Dec. 11, 2017, 9:20 a.m. UTC
Add device tree bindings for MLX90632 IR temperature sensor.

Signed-off-by: Crt Mori <cmo@melexis.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../bindings/iio/temperature/mlx90632.txt          | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/temperature/mlx90632.txt

Comments

Andreas Färber Dec. 12, 2017, 5:45 p.m. UTC | #1
Am 11.12.2017 um 10:20 schrieb Crt Mori:
> Add device tree bindings for MLX90632 IR temperature sensor.
> 
> Signed-off-by: Crt Mori <cmo@melexis.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
>  .../bindings/iio/temperature/mlx90632.txt          | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
> new file mode 100644
> index 000000000000..0b05812001f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
[...]
> +Example:
> +
> +mlx90632@3a {

Shouldn't the node name be more general like temperature@3a?

> +	compatible = "melexis,mlx90632";
> +	reg = <0x3a>;
> +};

Also generally the dt-bindings patch should go before the first use of
the compatible string.

Regards,
Andreas
Crt Mori Dec. 12, 2017, 7:19 p.m. UTC | #2
On 12 December 2017 at 18:45, Andreas Färber <afaerber@suse.de> wrote:
> Am 11.12.2017 um 10:20 schrieb Crt Mori:
>> Add device tree bindings for MLX90632 IR temperature sensor.
>>
>> Signed-off-by: Crt Mori <cmo@melexis.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>  .../bindings/iio/temperature/mlx90632.txt          | 28 ++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
>>
>> diff --git a/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
>> new file mode 100644
>> index 000000000000..0b05812001f8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
> [...]
>> +Example:
>> +
>> +mlx90632@3a {
>
> Shouldn't the node name be more general like temperature@3a?
>

None of the current temperature drivers have that, but it would be
nice for portability. I can prepare a patch to fix them all (a quick
check confirmed it is not consistent in pressure and light as well)

>> +     compatible = "melexis,mlx90632";
>> +     reg = <0x3a>;
>> +};
>
> Also generally the dt-bindings patch should go before the first use of
> the compatible string.
>

OK, will keep in mind in case of v5 to reorder the commits once again.

Best regards,
Crt
> Regards,
> Andreas
>
> --
> SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox

diff --git a/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
new file mode 100644
index 000000000000..0b05812001f8
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/temperature/mlx90632.txt
@@ -0,0 +1,28 @@ 
+* Melexis MLX90632 contactless Infra Red temperature sensor
+
+Link to datasheet: https://www.melexis.com/en/documents/documentation/datasheets/datasheet-mlx90632
+
+There are various applications for the Infra Red contactless temperature sensor
+and MLX90632 is most suitable for consumer applications where measured object
+temperature is in range between -20 to 200 degrees Celsius with relative error
+of measurement below 1 degree Celsius in object temperature range for
+industrial applications. Since it can operate and measure ambient temperature
+in range of -20 to 85 degrees Celsius it is suitable also for outdoor use.
+
+Be aware that electronics surrounding the sensor can increase ambient
+temperature. MLX90632 can be calibrated to reduce the housing effect via
+already existing EEPROM parameters.
+
+Since measured object emissivity effects Infra Red energy emitted, emissivity
+should be set before requesting the object temperature.
+
+Required properties:
+  - compatible: should be "melexis,mlx90632"
+  - reg: the I2C address of the sensor (default 0x3a)
+
+Example:
+
+mlx90632@3a {
+	compatible = "melexis,mlx90632";
+	reg = <0x3a>;
+};