| Message ID | 20171212081148.9194-5-wens@csie.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hi, On Tue, Dec 12, 2017 at 04:11:48PM +0800, Chen-Yu Tsai wrote: > This patch enables a PiFi DAC+ V2.0, which is a PCM5122-based audio > output DAC add-on board for the Raspberry Pi B+ and later, connected > to the GPIO header of the Bananapi M3 via jumper cables. The power, > ground, and I2C pins are in the same position, but the I2S ones are > not. > > The I2C controller used is I2C2, while the I2S controller is I2S1. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> > --- > > I'm sure I've asked this before, and IIRC the answer was yes: The I2C > controllers available on the GPIO header all have proper, always-on, > external pull-ups. Does that mean we can enable them by default, seeing > as they are likely intended to be used this way (as I2C pins)? > > I think we have a few boards where either I2C or UARTs on the GPIO > header are enabled by default. The consensus we reached that we would fill the nodes, but leave them disabled. In this particular case, I guess it would help for the i2c controller, but not for the i2s one. Maxime
diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts index 6550bf0e594b..a9a208ebda12 100644 --- a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts +++ b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts @@ -70,6 +70,23 @@ gpio = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */ }; + sound { + compatible = "simple-audio-card"; + simple-audio-card,name = "PiFi DAC+ v2.0"; + simple-audio-card,format = "i2s"; + simple-audio-card,mclk-fs = <512>; + simple-audio-card,frame-master = <&link_cpu>; + simple-audio-card,bitclock-master = <&link_cpu>; + + link_cpu: simple-audio-card,cpu { + sound-dai = <&i2s1>; + }; + + simple-audio-card,codec { + sound-dai = <&pcm5122>; + }; + }; + wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; clocks = <&ac100_rtc 1>; @@ -100,6 +117,22 @@ status = "okay"; }; +&i2c2 { + pinctrl-names = "default"; + pinctrl-0 = <&i2c2_ph_pins>; + status = "okay"; + + pcm5122: pcm5122@4d { + #sound-dai-cells = <0>; + compatible = "ti,pcm5122"; + reg = <0x4d>; + }; +}; + +&i2s1 { + status = "okay"; +}; + &mdio { rgmii_phy: ethernet-phy@1 { compatible = "ethernet-phy-ieee802.3-c22";
This patch enables a PiFi DAC+ V2.0, which is a PCM5122-based audio output DAC add-on board for the Raspberry Pi B+ and later, connected to the GPIO header of the Bananapi M3 via jumper cables. The power, ground, and I2C pins are in the same position, but the I2S ones are not. The I2C controller used is I2C2, while the I2S controller is I2S1. Signed-off-by: Chen-Yu Tsai <wens@csie.org> --- I'm sure I've asked this before, and IIRC the answer was yes: The I2C controllers available on the GPIO header all have proper, always-on, external pull-ups. Does that mean we can enable them by default, seeing as they are likely intended to be used this way (as I2C pins)? I think we have a few boards where either I2C or UARTs on the GPIO header are enabled by default. --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)