From patchwork Wed Dec 13 03:51:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changwei Ge X-Patchwork-Id: 10109177 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BC16560327 for ; Wed, 13 Dec 2017 03:53:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F4082902D for ; Wed, 13 Dec 2017 03:53:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9249E2904E; Wed, 13 Dec 2017 03:53:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 329842902D for ; Wed, 13 Dec 2017 03:53:32 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBD3qBxh071844; Wed, 13 Dec 2017 03:52:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : date : message-id : mime-version : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : content-type : content-transfer-encoding : sender; s=corp-2017-10-26; bh=hgqSDrHA2HP/r6fJEebenkTckVUR85Iq5En+AvLy3GU=; b=IV8i6lnKQponOFoiYLtshPlaNf/rdpgDic9DCh5CaoBmU2xdF7Eu4JZ+R2KtUQfgXVh4 uK/YE64ZlFallJIoOiKAMm9bknMdAZ/176czVAcUtfZOVhNX4SimGvKUd8x+W+dMwDPm RkrbLXR/Waj+qJAY5qfx59AI3kgGsNs1NtXO9RO8gYQB1QLB2sjLPnp46QPEjqVJeR2G +3lAeutjsNecU462pkYFPmEUDLxXxAO7/Rq1tdl5E/Qm4mtBDLbEje9URjuuknJTFDWt u7ui0SDmaiXo+Tc+Dl5ZAMFNPQidLvqNB3z2jd55S/jnX1Lj1e4FmELhQFIWvd8SdGFg 8w== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2etvg5r13b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Dec 2017 03:52:33 +0000 Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBD3qQF3018067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Dec 2017 03:52:27 GMT Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1eOy5q-0001Ee-HF; Tue, 12 Dec 2017 19:52:26 -0800 Received: from aserv0022.oracle.com ([141.146.126.234]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1eOy5m-0001DF-PE for ocfs2-devel@oss.oracle.com; Tue, 12 Dec 2017 19:52:22 -0800 Received: from userp2040.oracle.com (userp2040.oracle.com [156.151.31.90]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id vBD3qLhL016779 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=OK) for ; Wed, 13 Dec 2017 03:52:22 GMT Received: from pps.filterd (userp2040.oracle.com [127.0.0.1]) by userp2040.oracle.com (8.16.0.21/8.16.0.21) with SMTP id vBD3ljgR021528 for ; Wed, 13 Dec 2017 03:52:21 GMT Received: from h3cmg01-ex.h3c.com (smtp.h3c.com [60.191.123.56]) by userp2040.oracle.com with ESMTP id 2etrgecxnd-1 for ; Wed, 13 Dec 2017 03:52:11 +0000 Received: from BJHUB02-EX.srv.huawei-3com.com (unknown [10.63.20.170]) by h3cmg01-ex.h3c.com with smtp id 4680_0439_73ab325b_8f25_41a0_b79c_db46100324c9; Wed, 13 Dec 2017 11:51:23 +0800 Received: from H3CMLB14-EX.srv.huawei-3com.com ([fe80::f804:6772:bd71:f07f]) by BJHUB02-EX.srv.huawei-3com.com ([::1]) with mapi id 14.03.0248.002; Wed, 13 Dec 2017 11:51:15 +0800 From: Changwei Ge To: Andrew Morton , "ocfs2-devel@oss.oracle.com" , Joseph Qi Thread-Topic: [PATCH v2] ocfs2: clean dead code in suballoc.c Thread-Index: AdNzxZ7Pt89SfWvpQPWrDJGr/iszww== Date: Wed, 13 Dec 2017 03:51:13 +0000 Message-ID: <63ADC13FD55D6546B7DECE290D39E373F1F5A842@H3CMLB14-EX.srv.huawei-3com.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.125.136.231] MIME-Version: 1.0 X-CLX-Shades: MLX X-CLX-Response: 1TFkXGx4aEQpMehcaEQpZTRdnZnIRCllJFxpxGhAadwYbGBpxGRsQG3cGGBo GGhEKWV4XaG55EQpJRhdFWEtJRk91WlhFTl9JXkNFRBl1T0sRCkNOF214cE19E1J6fXlSc0dSRk 9cSUVSRGFyZ0QHW2RoelBuEQpYXBcfBBoEGxgYBxxLSEtPHhwaBRsaBBsaGgQeEgQbEBseGh8aE QpeWRd4cEFDexEKTVwXGRgSEQpMWhdoaUJNXREKTU4XaBEKTEYXY2sRCkNaFxwaBBsTGwQbGBkE HxwRCkJeFxsRCkReFx4RCkJGF2BTbh5DGXNnWEZmEQpCXBcaEQpCRRduGVhMXmEBcFJMYREKQk4 XZEJ8WkVEQWIdZFARCkJMF29+XU0YBV1mGlJ7EQpCbBdkYU9LYEJIEngdZxEKQkAXYl9OaEMaZV NuXFwRCkJYF2J9b3kBTxgZcHB7EQpwaBdhAWEbYxxFX3B7fhAaEQpwaBd6fRNJE3JfHnJwTxAcG hEKcGgXZhtMUBtrS2IFXRgQGhEKcGgXbm1dXxh5THx6RWcQHhIRCnBoF2hLHUB4T3JZYHoSEBoR CnBsF21OG29TAUdSSB1zEB4SEQptfhcaEQpYTRdLESA= X-PDR: PASS X-Source-IP: 60.191.123.56 X-ServerName: smtp.h3c.com X-Proofpoint-SPF-Result: temperror X-Proofpoint-SPF-Record: N/A X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=140 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130051 X-Spam: Clean Subject: [Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8743 signatures=668646 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1712130052 X-Virus-Scanned: ClamAV using ClamSMTP Stack variable fe is no longer used, so trim it to save some cpu cycles and stack space. Signed-off-by: Changwei Ge --- fs/ocfs2/suballoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) &bg_start_bit); diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index 71f22c8fbffd..508422b0032f 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c @@ -2566,16 +2566,16 @@ static int _ocfs2_free_clusters(handle_t *handle, int status; u16 bg_start_bit; u64 bg_blkno; - struct ocfs2_dinode *fe; /* You can't ever have a contiguous set of clusters * bigger than a block group bitmap so we never have to worry * about looping on them. * This is expensive. We can safely remove once this stuff has * gotten tested really well. */ - BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk))); + BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, + ocfs2_blocks_to_clusters(bitmap_inode->i_sb, + start_blk))); - fe = (struct ocfs2_dinode *) bitmap_bh->b_data; ocfs2_block_to_cluster_group(bitmap_inode, start_blk, &bg_blkno,